Skip to content

[FSSDK-11197] EventTags type fix #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 6, 2025

Conversation

junaed-optimizely
Copy link
Contributor

@junaed-optimizely junaed-optimizely commented May 2, 2025

Summary

EventTags type fix.
The issue that has been raised in React SDK - optimizely/react-sdk#303, that the $opt_event_properties does not support object even though the doc demonstrated so - https://docs.developers.optimizely.com/feature-experimentation/docs/track-event-javascript#example.

Test plan

Existing test should pass

Issues

FSSDK-11197

@coveralls
Copy link

coveralls commented May 2, 2025

Coverage Status

coverage: 80.717% (+0.002%) from 80.715%
when pulling f9a6ba3 on junaed/fssdk-11197-event-tag-type-fix
into dd66bea on master.

Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a clarification.

@junaed-optimizely junaed-optimizely requested a review from jaeopt May 5, 2025 16:44
@junaed-optimizely junaed-optimizely merged commit 32f857e into master May 6, 2025
17 checks passed
@junaed-optimizely junaed-optimizely deleted the junaed/fssdk-11197-event-tag-type-fix branch May 6, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants