Skip to content

update OptimizelyError message resolution #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025
Merged

update OptimizelyError message resolution #1052

merged 1 commit into from
May 15, 2025

Conversation

raju-opti
Copy link
Contributor

No description provided.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the error message resolution logic for the OptimizelyError class. Key changes include the removal of the getMessage method and modifications to the setMessage method to ensure the message is only set once.

Comments suppressed due to low confidence (2)

lib/error/optimizly_error.ts:33

  • The removal of the getMessage method changes the public API for error message resolution. Consider providing documentation or a migration note to help consumers transition to the new behavior.
-  getMessage(resolver?: MessageResolver): string {

lib/error/optimizly_error.ts:0

  • [nitpick] The filename 'optimizly_error.ts' may contain a typo relative to the class name 'OptimizelyError'. Consider renaming the file for consistency.
Filename: optimizly_error.ts

@coveralls
Copy link

coveralls commented May 14, 2025

Coverage Status

coverage: 80.685% (+0.04%) from 80.643%
when pulling f079735 on raju/errmsg
into e1190c6 on master.

@raju-opti raju-opti merged commit 3c63d79 into master May 15, 2025
16 of 17 checks passed
@raju-opti raju-opti deleted the raju/errmsg branch May 15, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants