Skip to content

[FSSDK-11509] Remove optional netinfo require #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 15, 2025

Conversation

junaed-optimizely
Copy link
Contributor

Summary

Making netinfo mandatory

Test plan

Existing tests have been modified

Issues

FSSDK-11509

@coveralls
Copy link

coveralls commented May 15, 2025

Coverage Status

coverage: 80.428%. remained the same
when pulling 861f338 on junaed/fssdk-11509-netinfo-require-error
into 4d2a4e1 on master.

Copy link
Contributor

@raju-opti raju-opti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. few small suggestions

@junaed-optimizely junaed-optimizely merged commit 2b97b44 into master May 15, 2025
15 of 17 checks passed
@junaed-optimizely junaed-optimizely deleted the junaed/fssdk-11509-netinfo-require-error branch May 15, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants