[FSSDK-11577] Ruby: Add holdout support and refactor decision logic in DefaultDecisionService #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n DefaultDecisionService
alexjoeyyong
approved these changes
Oct 13, 2025
lib/optimizely/decision_service.rb
Outdated
Comment on lines
314
to
321
| decision_result = get_decision_for_flag( | ||
| feature_flag, | ||
| user_context, | ||
| project_config, | ||
| decide_options, | ||
| user_profile_tracker, | ||
| [] | ||
| ) |
There was a problem hiding this comment.
Is this relevant to holdout changes? I am pretty sure this is causing the cmab errors.
esrakartalOpt
deleted the
esra/FSSDK-11577_holdout_support_decision_service
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
PR checks
Issues