test(release): systemd unit starts and serves - #229
Open
aarushlohit wants to merge 4 commits into
Open
Conversation
Signed-off-by: Aarush Lohit <141929019+aarushlohit@users.noreply.github.com>
Signed-off-by: Aarush Lohit <141929019+aarushlohit@users.noreply.github.com>
|
🚀 First PR — welcome aboard! A few things to expect:
If you get stuck, reply here or jump to Discussions. We want this PR to land. |
aarushlohit
marked this pull request as ready for review
June 27, 2026 12:52
Author
… root - go.mod: promote github.com/docker/docker from indirect to direct (directly imported in systemd_service_test.go) - integrationRepoRoot: replace runtime.Caller with os.Getwd + upward walk-to-go.mod (fixes 'chdir' failure under -trimpath on CI)
Author
|
@optiqor kindly review it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Adds release-focused integration coverage for the bare-metal startup path.
kerno start, waits for/healthz, and verifies clean SIGTERM shutdown/etc/systemd/system, copies the built binary to/usr/bin/kerno, runssystemctl start kerno, verifies the unit reachesactive, checks/healthz, and confirmssystemctl stopreturns the unit toinactivesystemctl statusandjournalctloutput on failure for faster diagnosisWhy
Fixes #155.
The package-install checks verify that the systemd unit is present, but they do not prove that the unit's
ExecStartpath and runtime wiring actually work. This change closes that gap by validating the installed unit in a real systemd-capable container, while keeping the test inside the existing Go integration suite instead of adding a host-level CI job.Impact
ExecStartpathsinternal/integrationtesting modelValidation
go test ./... -count=1go test ./internal/integration -tags integration -run TestStartCommandServesHealthAndStopsCleanly -count=1go test ./internal/integration -tags integration -run TestSystemdUnitStartsAndServesHealthz -count=1