Skip to content
This repository was archived by the owner on Aug 18, 2023. It is now read-only.

Fix #2 : Updated to work on Windows #9

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

HopHouse
Copy link

I made few minor changes to the code in order to make it works on Windows and closing issue #2 :

  • I update garble to the version v0.9.3 ;
  • I changed hard-coded paths and used filepath to construct the paths ;
  • I modified into the Struct module the necessary of the log package which made the compiler scream either you are compiling a dll or an exe. I removed dependencies to log in the profit of fmt ;
  • I added more verbose about the code which is executed if the user wants to debug/try the commands itself ;
  • When random names were generated I had issues. Each time the code was running, it uses a generator based on the time and date, but it was always initialised again. If you computer is fast enough, you will use the same seed, and therefore generate same random names. In order to avoid this, I changed the code structure in order to initialised only once.

Please let me know if you want me to modify/add things about my pull request.

@HopHouse
Copy link
Author

Following you last improvement on the code, I did replace the hard-coded version of garble to the latest tag.

@HopHouse HopHouse mentioned this pull request May 16, 2023
@PocketDC PocketDC mentioned this pull request May 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant