Skip to content

bug in preprocessing handling #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

bug in preprocessing handling #947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ef4b9a9
Update forecast_datasets.py
ahosler Aug 5, 2024
d90de7f
Update automlx.py
ahosler Aug 13, 2024
ebcb491
Merge branch 'main' into ahosler-patch-1
ahosler Aug 13, 2024
56c69e6
Merge branch 'main' into ahosler-patch-2
ahosler Aug 20, 2024
585e1df
Merge branch 'main' into ahosler-patch-1
ahosler Sep 17, 2024
f8acd71
Merge branch 'main' into ahosler-patch-2
ahosler Sep 19, 2024
0b43f62
Merge branch 'main' into ahosler-patch-1
ahosler Sep 19, 2024
b9999c1
Update forecast_datasets.py (#923)
ahosler Sep 19, 2024
9e8fe78
Merge branch 'main' into ahosler-patch-2
ahosler Sep 20, 2024
2d87903
Merge branch 'main' into ahosler-patch-2
ahosler Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ads/opctl/operator/lowcode/forecast/model/automlx.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def set_kwargs(self):
time_budget = model_kwargs_cleaned.pop("time_budget", -1)
model_kwargs_cleaned[
"preprocessing"
] = self.spec.preprocessing or model_kwargs_cleaned.get("preprocessing", True)
] = self.spec.preprocessing.enabled or model_kwargs_cleaned.get("preprocessing", True)
return model_kwargs_cleaned, time_budget

def preprocess(self, data, series_id=None): # TODO: re-use self.le for explanations
Expand Down
2 changes: 1 addition & 1 deletion ads/opctl/operator/lowcode/forecast/model/forecast_datasets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ def __init__(self, spec, historical_data):
add_dates.sort()
if historical_data.get_max_time() > add_dates[-spec.horizon]:
raise DataMismatchError(
f"The Historical Data ends on {historical_data.get_max_time()}. The additional data horizon starts on {add_dates[-spec.horizon]}. The horizon should have exactly {spec.horizon} dates after the Hisotrical at a frequency of {historical_data.freq}"
f"The Historical Data ends on {historical_data.get_max_time()}. The additional data horizon starts on {add_dates[-spec.horizon]}. The horizon should have exactly {spec.horizon} dates after the Historical at a frequency of {historical_data.freq}"
)
elif historical_data.get_max_time() != add_dates[-(spec.horizon + 1)]:
raise DataMismatchError(
Expand Down