-
Notifications
You must be signed in to change notification settings - Fork 34
OIDC feature #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
OIDC feature #423
Conversation
Unit tests:
E2E Tests:
|
@@ -653,6 +738,21 @@ func (s *ManagedControlPlaneScope) UpdateControlPlane(ctx context.Context, okeCl | |||
return false, nil | |||
} | |||
|
|||
// compareSpecs compares two OCIManagedControlPlaneSpec objects for equality | |||
func (s *ManagedControlPlaneScope) compareSpecs(spec1, spec2 *infrastructurev1beta2.OCIManagedControlPlaneSpec) bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts on adding some quick unit tests around this new function?
} | ||
|
||
// KeyValue defines the properties that define a key value pair. This is alias to containerengine.KeyValue, to support the sdk type | ||
type KeyValue containerengine.KeyValue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't fully understand this one. What is going on here?
What this PR does / why we need it:|
This feature adds the newly announced OIDC configuration into the cluster api. This allows users to provision OKE clusters with the correct OIDC settings in one go.
Which issue(s) this PR fixes:
Fixes #391
Note: Due to the nested structs - I followed conventions in other cluster-api operators and imported go-cmp to better evaluate the differences due to the issues with deepequal