Skip to content

Fix Cdist - Preserve dimensions when casting a vector to double #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Cdist - Preserve dimensions when casting a vector to double #99

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions com.oracle.truffle.r.library/src/com/oracle/truffle/r/library/stats/Cdist.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public abstract class Cdist extends RExternalBuiltinNode.Arg4 {

static {
Casts casts = new Casts(Cdist.class);
casts.arg(0).mustBe(nullValue().not(), RError.Message.VECTOR_IS_TOO_LARGE).mustBe(missingValue().not()).asDoubleVector();
casts.arg(0).mustBe(nullValue().not(), RError.Message.VECTOR_IS_TOO_LARGE).mustBe(missingValue().not()).asDoubleVector(true,true,true);
casts.arg(1).asIntegerVector().findFirst();
casts.arg(2).mustBe(instanceOf(RList.class));
casts.arg(3).asDoubleVector().findFirst();
Expand All @@ -68,7 +68,7 @@ protected RDoubleVector cdist(RAbstractDoubleVector x, @SuppressWarnings("unused
@Cached("create()") GetDimAttributeNode getDimNode) {
if (!getDimNode.isMatrix(x)) {
// Note: otherwise array index out of bounds
throw error(Message.MUST_BE_SQUARE_MATRIX, "x");
throw error(Message.NON_MATRIX, "dist");
}
int nr = getDimNode.nrows(x);
int nc = getDimNode.ncols(x);
Expand Down