[GR-61712] Trace zip file entries loaded from classpath zips as resources. #10677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The XML framework does not always load resources using traced APIs like
getResource. For example, if an XSD (schema) file "include"s another file, it gets loading using ajar:file:<jarfile>!/<entry>URL.There is no perfect call site to identify this access pattern (to my knowledge). The heuristic I chose is to trace
ZipFile#getEntryinvocations where the zip/jar file belongs to the classpath (while also filteringMETA-INFand*.classentries). This seems to do the trick, at least on the reproducer, without creating any extraneous entries.