pdpdevtool 6260 dev assist not handling user ports proxy service dev #963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify versioning
…ets-and-terms-release-branch Feature/pdpdevtool 6197 fix brackets and terms release branch
…3_merge_dev_with_release_25.2 # Conflicts: # packages/node-cli/src/metadata/SdkCommandsMetadataPatch.json
…_with_release_25.2 Feature/pdpdevtool 6203 merge dev with release 25.2
…adme-for-js-tools Versioning changes
improve devassist settings fix devassistStatusBar tooltip message
…admes-for-js-tools-select-flag-update Add select flag update
…Id validation messages (#955) * Fix * Removing duplicated code * OCD goes hard in this economy ++ pushing vscode package lock by mistake
…51-developer-assistant-naming
…-error-messages PDPDEVTOOL-6199-fix-proxy-error-messages
…-assistant-naming feature/pdpdevtool-6251: developer assistant naming
oracle-contributor-agreement
bot
added
the
OCA Verified
packages/vscode-extension/src/startup/DevAssistConfiguration.ts
Outdated
Show resolved
Hide resolved
bugfix/proxy host header
TheJorgeBorras
approved these changes
Oct 23, 2025
| const errorMsg = NodeTranslationService.getMessage(DEV_ASSIST_PROXY_SERVICE.ALREADY_USED_PORT, proxyPort); | ||
| this._handleListeningPortError(errorMsg, EVENTS.ALREADY_USED_PORT); | ||
| } else { | ||
| const errorMsg = NodeTranslationService.getMessage(DEV_ASSIST_PROXY_SERVICE.LISTENING_PORT_ERROR, proxyPort, error.message ?? ''); |
There was a problem hiding this comment.
instead of error.message ?? '', maybe we could go for "\n" + error.message ?? ''.
This way we introduce a lineskip between the generic message and the actual cause of the error (which should result in better UX).
Feel fee to ignore this comment, I don't feel like it's important enough to block the PR.
TheJorgeBorras
approved these changes
Oct 23, 2025
This reverts commit 46dd42a.
propagate/release25.2-into-dev
|
Removed due to merge problems |
carolnavarropereira
deleted the
bugfix/PDPDEVTOOL-6260-DevAssist-not-handling-user-ports-proxy-service-dev
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.