Skip to content
This repository was archived by the owner on Oct 31, 2019. It is now read-only.

add support for multiple compartments as per sod #175

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

srirg
Copy link
Contributor

@srirg srirg commented Mar 23, 2018

This PR is a fix for #166

@garthy
Copy link
Member

garthy commented Mar 27, 2018

I'm not sure the multiple_compartments flag is needed. Can you just use the value if set? e.g:-

network_compartment_ocid = "${(var.network_compartment_ocid != "") ? var.network_compartment_ocid : var.compartment_ocid}"

Also can you rebase + squash to master and split the functionally out into a clean merge request with structured descriptive commit message(s). At the moment this change has many features including a bastion change with many unneeded commit messages.

Thanks

@srirg srirg force-pushed the multiple branch 5 times, most recently from bb65c10 to ab6ac47 Compare March 28, 2018 02:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants