Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] refactor: use handlers for oras blob push command #1618

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

wangxiaoxuan273
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #1542

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 51.78571% with 27 lines in your changes missing coverage. Please review.

Project coverage is 84.07%. Comparing base (da1daf0) to head (a6fca24).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/oras/internal/display/status/tty.go 0.00% 19 Missing ⚠️
cmd/oras/internal/display/status/text.go 73.33% 4 Missing ⚠️
cmd/oras/root/blob/push.go 63.63% 2 Missing and 2 partials ⚠️

❌ Your patch check has failed because the patch coverage (51.78%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1618      +/-   ##
==========================================
- Coverage   84.41%   84.07%   -0.34%     
==========================================
  Files         120      121       +1     
  Lines        5460     5507      +47     
==========================================
+ Hits         4609     4630      +21     
- Misses        604      629      +25     
- Partials      247      248       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Xiaoxuan Wang and others added 2 commits February 10, 2025 16:04
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: wangxiaoxuan273 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant