Fill in gaps in @orbit/validators #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simply verifies `typeof` input.
If a validator can't be found for a particular `type`, then the `unknown` validator will be returned (if one has been registered in `buildValidatorFor`).
joelgallant
reviewed
Jul 7, 2021
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| options?: ObjectValidationOptions | ||
| ): undefined | ObjectValidationIssue[] => { | ||
| if (typeof input !== 'object') { |
There was a problem hiding this comment.
@joelgallant - ah good catch! This won't have practical implications when used to validate attributes of type object because null will be caught first.
Regardless, the object validator should work well on its own and should probably not accept null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performs the tasks discussed in #857:
validateObjectand registers it instandardValidatorsforobjecttypesvalidateDateinstandardValidatorsfordatetimetypes (it's already registered fordatetypes)unknownvalidator to allow for a catch-all for validating types that don't have a registered validator (similar to theunknownserializer concept). This can be used as a no-op, or to log an error, or even to throw an exception.Closes #857