Skip to content

remove the tmpdir after orca-cli installation #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raghur-orca wants to merge 1 commit into
base: main
Choose a base branch
from
Open

remove the tmpdir after orca-cli installation #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ execute() {
# test if Rosetta2 is present
/usr/bin/pgrep -q oahd || log_info "M1 CPU requires Rosetta 2, which appears to be missing. Install it by running: '/usr/sbin/softwareupdate --install-rosetta'"
fi

rm -rf "${tmpdir}"
Copy link

@yinonsh-orca yinonsh-orca Jul 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is very dangerous, in case of issues we might delete customer data. is it really necessary ?

Copy link
Author

@raghur-orca raghur-orca Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yinonsh-orca We delete the temporary directory which we have created for orca-cli installation:
tmpdir=$(mktmpdir)
After installing the orca-cli, we should be OK to delete the directory created by us.

Copy link
Author

@raghur-orca raghur-orca Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yinonsh-orca / @liorj-orca Any thoughts on my last comment.?

Copy link

@yinonsh-orca yinonsh-orca Aug 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the directory is created under /tmp, there's no need to delete it.

@liorj-orca what do you think ? Was this raised by customers ?

}


Expand Down