Skip to content

Remove setuptools from install_requires #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove setuptools from install_requires #178

wants to merge 1 commit into from

Conversation

hexponent
Copy link

I believe setuptools is redundant here.

Two reasons for that:

  1. There are no mentions of setuptools (or other things distributed with it) in the code
  2. If I build a wheel manually and than install it in a separate environment with no setuptools - not only it is installed successfully, but also importing fitbit and running some code (e.g. Fitbit.time_series) succeeds

@hexponent
Copy link
Author

@brad please review. Is the project still maintained?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hexponent