feat(cost-explorer): AnomalyMonitor and AnomalySubscription type - #39
Open
OlafConijn wants to merge 3 commits into
Open
feat(cost-explorer): AnomalyMonitor and AnomalySubscription type#39OlafConijn wants to merge 3 commits into
OlafConijn wants to merge 3 commits into
Conversation
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
=======================================
Coverage 82.71% 82.71%
=======================================
Files 12 12
Lines 972 972
Branches 141 141
=======================================
Hits 804 804
Misses 168 168
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
OlafConijn
marked this pull request as ready for review
November 12, 2020 11:09
OlafConijn
changed the title
OlafConijn
changed the title
| await service.deleteAnomalyMonitor({ MonitorArn: model.arn }).promise(); | ||
|
|
||
| return Promise.resolve(null); | ||
| } |
| model.arn = response.MonitorArn; | ||
| return Promise.resolve(model); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Why there is no update handler?
| @@ -0,0 +1,18 @@ | |||
| # Distribution / packaging | |||
| @@ -0,0 +1,18 @@ | |||
| # Distribution / packaging | |||
| "cfn-rpdk": "npm:@org-formation/cfn-rpdk@^0.4.0", | ||
| "class-transformer": "^0.3.1", | ||
| "uuid": "^7.0.3", | ||
| "aws-sdk": "2.775.0" |
Member
There was a problem hiding this comment.
aws sdk should be moved to optional dependencies, because the minimum lambda version now is 2.771.0
| "devDependencies": { | ||
| "@types/node": "^12.0.0", | ||
| "@types/uuid": "^7.0.3", | ||
| "typescript": "^3.8.3" |
Member
There was a problem hiding this comment.
this should be "typescript": "^4.1.2" to make sure we use the hoisted version across the whole repository
| }, | ||
| "dependencies": { | ||
| "aws-resource-providers-common": "^0.2.0", | ||
| "cfn-rpdk": "npm:@org-formation/cfn-rpdk@^0.4.0", |
| "test": "echo \"Error: no test specified\" && exit 1" | ||
| }, | ||
| "dependencies": { | ||
| "aws-resource-providers-common": "^0.2.0", |
| "devDependencies": { | ||
| "@types/node": "^12.0.0", | ||
| "@types/uuid": "^7.0.3", | ||
| "typescript": "^3.8.3" |
Member
There was a problem hiding this comment.
this should be "typescript": "^4.1.2"
| "cfn-rpdk": "npm:@org-formation/cfn-rpdk@^0.4.0", | ||
| "class-transformer": "^0.3.1", | ||
| "uuid": "^7.0.3", | ||
| "aws-sdk": "2.775.0" |
| "test": "echo \"Error: no test specified\" && exit 1" | ||
| }, | ||
| "dependencies": { | ||
| "aws-resource-providers-common": "^0.2.0", |
| }, | ||
| "dependencies": { | ||
| "aws-resource-providers-common": "^0.2.0", | ||
| "cfn-rpdk": "npm:@org-formation/cfn-rpdk@^0.4.0", |
Contributor
|
@OlafConijn i think AWS has a CFN resource for this now? https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ce-anomalymonitor.html |
OlafConijn
force-pushed
the
master
branch
2 times, most recently
from
December 10, 2022 09:48
9d87809 to
cec8fd2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #36
Description of changes: