-
Notifications
You must be signed in to change notification settings - Fork 13
Allow running regress check with orioledb #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Different output for float4/8 ordering is seen for orioledb tables. Though tests with this commit IMO will run with heap tables. float8.patch/float4.patch look unused in this PR. Maybe they could be added later.
Yeah, anyway, given this upstream patch, there is now no need to patch float4/8 files. I'll remove them |
The idea of this pr is to add patches and tweaks here, that I can later apply in orioledb CI to run check-world with orioledb AM |
It's still needed in PG17/PG16 because the patch is committed into the future PG18 without backpatching. |
I am planning to apply the upstream patch in oriole db ci directly, I'll add it in the next pr and will link it here |
I definitely appreciate the idea to run the tests on Orioledb AM. And I would be glad to review a full set of patches to Postgres and Orioledb together and then merge to main branches into both repositories. |
Thanks @pashkinelfe I'll request your review, when the second patch is finished |
LGTM. I requested to change path in Oriole patchset accordingly. After that I'm planning to merge. |
Along with this mr I plan to integrate this to orioledb pipeline, before venturing further to fix tests.
Of course in the pipeline some initial setup will be required.