Initialize isLocal if temp tables are available #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pashkinelfe
requested changes
May 28, 2025
There was a problem hiding this comment.
isLocal doesn't exist in SharedInvalidationMessage in the scope of Oriole patchset
I think that Oriole PG patchset is not the right place for this change. Ideally there should be a special repo outside Oriole that provides compatibility of Oriole with the feature that introduces msg.isLocal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If message has
isLocalfield and it is not initialized, it contains garbage value, which is usually evaluated to true, which is incorrect in general case, by default cache is not local.