feat(push): adds build and push functionality into different subcommands #21
Conversation
jpower432
force-pushed
the
feat/push-command
branch
from
6256b69 to
1778bec
Compare
jpower432
changed the title
jpower432
force-pushed
the
feat/push-command
branch
from
1e97483 to
773dedd
Compare
Closes ortelius#6 Signed-off-by: Jennifer Power <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
Returning the descriptors allows for easier testing of concrete implementations of the Client interface and allows for post-processing on descriptors. Signed-off-by: Jennifer Power <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
jpower432
force-pushed
the
feat/push-command
branch
from
f07d7af to
ba47d49
Compare
cli/build.go
Outdated
| # Template content in a directory and push to a registry location | ||
| client build <directory> --push --destination localhost:5000/myartifacts:latest | ||
| # Template content into a specified output directory. | ||
| client build mydirectory myoutputdirectory |
There was a problem hiding this comment.
Need to specify --output flag
cli/build.go
Outdated
| # Template content in a directory without pushing | ||
| client build <directory> | ||
| # Template content in a directory | ||
| client build mydirectory |
There was a problem hiding this comment.
Does this template the content from the specified directory into the current directory?
There was a problem hiding this comment.
There is a default workspace called "client-workspace" that is created in the current directory if the --ouput flag is not used. The content is taken from the specified directory and templated into that directory or whatever workspace is defined with the --output flag.
There was a problem hiding this comment.
Added that info the example text
cli/build.go
Outdated
| # Template content in a directory without pushing | ||
| client build <directory> | ||
| # Template content in a directory | ||
| client build mydirectory |
There was a problem hiding this comment.
In the output of the command, do we want to mention where the workspace directory is located?
There was a problem hiding this comment.
There is a log output at the end of the command that gives instructions on how to publish the rendered content with the workspace information. It is also logged at the beginning of the operation, but at the debug level. Do you think that is worth bumping to info?
There was a problem hiding this comment.
At this point, would like to lower the barrier of entry as much as possible, So recommend adding it at Info level
Co-authored-by: Andrew Block <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
…nds (ortelius#21) * feat(push): adds build and push functionality into different subcommands Closes ortelius#6 Signed-off-by: Jennifer Power <[email protected]> * docs: updates README.md with new usage directions for push Signed-off-by: Jennifer Power <[email protected]> * feat: changes Client interface to allow the descriptors be returned Returning the descriptors allows for easier testing of concrete implementations of the Client interface and allows for post-processing on descriptors. Signed-off-by: Jennifer Power <[email protected]> * chore: comment clean up in graph and builder packages Signed-off-by: Jennifer Power <[email protected]> * chore: update README.md with user workflow Signed-off-by: Jennifer Power <[email protected]> * test: adds artifact digest checking on build unit tests Signed-off-by: Jennifer Power <[email protected]> * chore: adds logger to push command Signed-off-by: Jennifer Power <[email protected]> * test(cli): adds logger to push e2e test Signed-off-by: Jennifer Power <[email protected]> * Update README.md Co-authored-by: Andrew Block <[email protected]> * docs: adds correct output flags and fixes naming in examples Signed-off-by: Jennifer Power <[email protected]> * fix(build): bumps log about workspace to Info level in build command Signed-off-by: Jennifer Power <[email protected]> Co-authored-by: Andrew Block <[email protected]>
Closes #6
Signed-off-by: Jennifer Power [email protected]