fix(query): prioritize query over mutation for non-GET operations in generateQueryHook

[Edward-Upton]

Status

READY

Fix #2025

Description

Ensures that only one of the queries or mutations are generated, giving priority to queries.

Todos

• Tests
• Documentation
• Changelog Entry (unreleased)

Steps to Test or Reproduce

Run on the test repo that shows the bug in action

https://github.com/Edward-Upton/orval-duplicate-hook-bug

[melloware]

Running the tests now!

[soartec-lab]

@Edward-Upton

Thank you for the nice correction. I made a comment.
I think it needs to be reflected in the documentation, but I'll think about it for a bit.

[Edward-Upton]

I have resolved the comments, thanks for the review 😄

[soartec-lab]

@Edward-Upton
Thanks!
I thought about documentation. Please clarify the specifications in the guide for the following options.

1. Only valid when the verbs of the two mutations are not get and not query
2. Prioritize output.mutation over output.orverride.mutation

• https://orval.dev/reference/configuration/output#usemutation
• https://orval.dev/reference/configuration/output#usemutation

Could you update docs ?

[Edward-Upton]

I have updated the docs, and fixed the issue that was causing the build failure.

[soartec-lab]

It's good !

[AllieJonsson]

It seems like this change broke samples, where we now get multiple implementation of the hooks

[soartec-lab]

@AllieJonsson
Oh, will that be fixed by just re-running orval in samples?

[AllieJonsson]

@soartec-lab No, I tried generating samples in #2035 but the issue persists

[soartec-lab]

@AllieJonsson
Thanks for letting me know.

@Edward-Upton
It seems like the query is being treated as a mutation in a way that we didn't intend. Can you confirm this?

[AllieJonsson]

@soartec-lab isn't it weird that we don't see if samples break in the PR, but in the following PRs? That must mean that we don't correctly build/test samples?
Could we maybe try to add yarn update-samples to the workflow, before running yarn test:ci?
#2037