Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: translate {property} in missing property validation message #357

Merged
merged 1 commit into from
Feb 15, 2025

Conversation

jonas-jonas
Copy link
Member

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@jonas-jonas jonas-jonas self-assigned this Feb 15, 2025
Copy link

codecov bot commented Feb 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 50.52%. Comparing base (f3fad4d) to head (35a9c7e).
Report is 32 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
+ Coverage   42.43%   50.52%   +8.09%     
==========================================
  Files         136      138       +2     
  Lines        2008     2108     +100     
  Branches      288      314      +26     
==========================================
+ Hits          852     1065     +213     
+ Misses       1149     1031     -118     
- Partials        7       12       +5     
Components Coverage Δ
@ory/elements-react 47.27% <38.40%> (+10.48%) ⬆️
@ory/nextjs 64.33% <74.24%> (-1.65%) ⬇️

@jonas-jonas jonas-jonas merged commit 9257eec into main Feb 15, 2025
13 of 14 checks passed
@jonas-jonas jonas-jonas deleted the jonas-jonas/translatePropertyInMessage branch February 15, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant