Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: safari click handler and redirect handling #361

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

jonas-jonas
Copy link
Member

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@jonas-jonas jonas-jonas self-assigned this Feb 20, 2025
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 50.56%. Comparing base (f3fad4d) to head (a094d87).
Report is 35 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #361      +/-   ##
==========================================
+ Coverage   42.43%   50.56%   +8.13%     
==========================================
  Files         136      138       +2     
  Lines        2008     2106      +98     
  Branches      288      313      +25     
==========================================
+ Hits          852     1065     +213     
+ Misses       1149     1029     -120     
- Partials        7       12       +5     
Components Coverage Δ
@ory/elements-react 47.33% <39.39%> (+10.54%) ⬆️
@ory/nextjs 64.33% <74.24%> (-1.65%) ⬇️

@jonas-jonas jonas-jonas marked this pull request as ready for review February 20, 2025 15:42
@jonas-jonas jonas-jonas merged commit 832f00d into main Feb 20, 2025
16 checks passed
@jonas-jonas jonas-jonas deleted the jonas-jonas/safariFIxes branch February 20, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant