Skip to content

fix: incorrect response code on account linking #4336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Mar 11, 2025

BREAKING CHANGES: Account linking incorrectly returned a 200 OK status code even though the login flow was not completed successfully. Going forward, the correct 400 OK status code will be sent when using the API flow or Accept: application/json.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr requested a review from a team as a code owner March 11, 2025 12:30
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 50.33%. Comparing base (f475aea) to head (70c6cb3).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
x/http.go 60.00% 2 Missing ⚠️
selfservice/flow/login/handler.go 66.66% 1 Missing ⚠️
selfservice/flow/login/hook.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4336      +/-   ##
==========================================
- Coverage   50.33%   50.33%   -0.01%     
==========================================
  Files         372      372              
  Lines       27424    27428       +4     
==========================================
+ Hits        13804    13806       +2     
- Misses      12014    12016       +2     
  Partials     1606     1606              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aeneasr and others added 2 commits April 18, 2025 10:07
BREAKING CHANGE: Account linking incorrectly returned a 200 OK status code even though the login flow was not completed successfully. Going forward, the correct 400 OK status code will be sent when using the API flow or `Accept: application/json`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants