fix: apply strategy filters in identifier first as well #4352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4352 +/- ##
==========================================
+ Coverage 78.56% 78.57% +0.01%
==========================================
Files 366 369 +3
Lines 27168 27207 +39
==========================================
+ Hits 21344 21378 +34
+ Misses 4198 4197 -1
- Partials 1626 1632 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aeneasr
commented
Mar 21, 2025
aeneasr
force-pushed
the
fix-org-filter
branch
3 times, most recently
from
9202604 to
953a39d
Compare
zepatrik
requested changes
Mar 25, 2025
zepatrik
approved these changes
Mar 25, 2025
aeneasr
force-pushed
the
fix-org-filter
branch
3 times, most recently
from
bc35eb8 to
8288f7a
Compare
aeneasr
commented
Mar 25, 2025
| @@ -837,7 +846,7 @@ func (s *Strategy) linkCredentials(ctx context.Context, i *identity.Identity, to | |||
| creds, err := i.ParseCredentials(s.ID(), &conf) | |||
| if errors.Is(err, herodot.ErrNotFound) { | |||
| var err error | |||
| if creds, err = identity.NewCredentialsOIDC(tokens, provider, subject, organization); err != nil { | |||
| if creds, err = identity.NewOIDCLikeCredentials(tokens, s.ID(), provider, subject, organization); err != nil { | |||
There was a problem hiding this comment.
@hperl this was using OIDC credentials, the workaround was only possible in a very specific scenario prior.
hperl
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.