Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support importing more credentials #4361

Merged
merged 4 commits into from
Mar 25, 2025
Merged

feat: support importing more credentials #4361

merged 4 commits into from
Mar 25, 2025

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Mar 25, 2025

Adds support to import SAML credentials. SAML connections are only available in Ory Enterprise License / Ory Network.

@aeneasr aeneasr requested a review from a team as a code owner March 25, 2025 13:11
Adds support to import SAML credentials in Ory Enterprise License / Ory Network.
@aeneasr aeneasr changed the title feat: support importing SAML credentials in enterprise feat: support importing more credentials Mar 25, 2025
Copy link
Contributor

@hperl hperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I would just not make the SAML doc strings reference OIDC, since that would be an implementation detail.

Copy link

codecov bot commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 90.69767% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.60%. Comparing base (5f47ac4) to head (79aeddf).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
identity/handler_import.go 90.69% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4361      +/-   ##
==========================================
+ Coverage   78.56%   78.60%   +0.04%     
==========================================
  Files         366      366              
  Lines       27168    27206      +38     
==========================================
+ Hits        21344    21385      +41     
+ Misses       4198     4192       -6     
- Partials     1626     1629       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aeneasr
Copy link
Member Author

aeneasr commented Mar 25, 2025

Code doc addressed!

@aeneasr aeneasr enabled auto-merge (squash) March 25, 2025 14:27
@aeneasr aeneasr disabled auto-merge March 25, 2025 15:13
@aeneasr aeneasr merged commit 9a6dadf into master Mar 25, 2025
37 of 40 checks passed
@aeneasr aeneasr deleted the add-saml-import branch March 25, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants