Open
Conversation
Export functions
mkassaf
reviewed
Jan 7, 2024
| public class CompressFactory { | ||
| public static ICompress getCompressType(CompressType type) { | ||
| ICompress compressor = null; | ||
| if (type.equals(CompressType.ZIP)) { |
Collaborator
There was a problem hiding this comment.
we usually prefer to write it like this CompressType.ZIP.equals( .. to avoid null pointer exception
Comment on lines
+22
to
+38
| File file = new File(f); | ||
| ZipEntry entry = new ZipEntry(file.getName()); | ||
| zipOutputStream.putNextEntry(entry); | ||
| if (!file.exists()) { | ||
| throw new FileNotFoundException("File not found: " + f); | ||
| } | ||
| try (FileInputStream fileInputStream = new FileInputStream(file)) { | ||
| int len; | ||
| byte[] data = new byte[1024]; | ||
| while ((len = fileInputStream.read(data)) != -1) { | ||
| zipOutputStream.write(data, 0, len); | ||
| } | ||
| } catch (IOException e) { | ||
| log(Level.SEVERE, e.getMessage(), "CompressZIP", "compress"); | ||
| } finally { | ||
| zipOutputStream.closeEntry(); | ||
| } |
Collaborator
There was a problem hiding this comment.
none primitive method, you need to extract it
Comment on lines
+39
to
+45
| try { | ||
| if (!file.delete()) { | ||
| throw new FileDeletionException("File Deletion Failed"); | ||
| } | ||
| } catch (FileDeletionException e) { | ||
| log(Level.SEVERE, e.getMessage(), "CompressZIP", "compress"); | ||
| } |
Collaborator
There was a problem hiding this comment.
useless try-catch and throw
| } catch (FileDeletionException e) { | ||
| log(Level.SEVERE, e.getMessage(), "CompressZIP", "compress"); | ||
| } | ||
| }catch (NullPointerException e){ |
Collaborator
There was a problem hiding this comment.
very bad practice to have an empty catch block
instead, created new custom exception such as CompressZIPExecption as throw it
Comment on lines
+31
to
+38
| try { | ||
| File file = new File(textFile); | ||
| if (!file.delete()) { | ||
| throw new FileDeletionException("File Deletion Failed"); | ||
| } | ||
| } catch (FileDeletionException e) { | ||
| log(Level.SEVERE, e.getMessage(), "PDFConvertor", "ConvertTOPdf"); | ||
| } |
Comment on lines
+39
to
+40
| userType = userService.getUser(user).getUserType(); | ||
| transactions = paymentService.getTransactions(user); |
Collaborator
There was a problem hiding this comment.
both these service may throw exceptions so you have to split them into two retry blocks
| SimpleFormatter formatter = new SimpleFormatter(); | ||
| fileHandler.setFormatter(formatter); | ||
| } catch (SecurityException | IOException e) { | ||
| e.printStackTrace(); |
Collaborator
There was a problem hiding this comment.
you may exit the application if the logger failed to start
| if (ActivityServiceTypes.ACTIVITY_SERVICE.equals(type)) { | ||
| return new UserActivityService(); | ||
| } | ||
| else { |
Collaborator
There was a problem hiding this comment.
no need for else, you can directly throw the execption
| if (PaymentServiceTypes.PAYMENT_SERVICE.equals(type)) { | ||
| return new PaymentService(); | ||
| } | ||
| else { |
| if (UserServiceTypes.USER_SERVICE_PROXY.equals(type)) { | ||
| return new UserServiceProxy(); | ||
| } | ||
| else { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.