-
Notifications
You must be signed in to change notification settings - Fork 112
[RHEL 8.10] go.mod: bump osbuild/images to v0.40.1 #4759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: rhel-8.10.0
Are you sure you want to change the base?
Conversation
We're going to need more test setup fiddling |
1c50279
to
d4111be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting the CI work on the rhel-X.Y.0
branches is always soooo painful 😭
My random comments/thoughts:
- Are changes to
tools/koji-compose.py
needed when Koji test cases are not run as part of CI? We do not need to test Koji for the 8.10 update at all. - The same applies to the Cloud API tests (
api.sh
) - we don't need to keep testing them. - The triggering of nightly tests in
.github/workflows/trigger-gitlab.yml
needs to be removed. - In general, I found it easier to read to have a separate PR to reduce CI and get it working on 8.10, and then have a new PR that does the required changes. This way, we will verify if the update works correctly, as now you risk losing changes to CI that are necessary due to the images update, among other changes.
Reduce test configurations to only run on and for RHEL 8.10 and bump the terraform commit ID. Update all GitHub runners to Ubuntu 22.04 (from 20.04, deprecated). Install dnf4 in the Python Lint job for dnf-json since it runs on Fedora 41 now.
We're using a newer linter now. Fix up the minor issues in the python scripts.
d4111be
to
943afb0
Compare
Not really no. But I had to update the Lint job runner, which updated the linter, which caught issues with the old version of the script. So I decided it's simpler to pull in the new version of the script to make the linter happy rather than disable the check. If the changes were more substantial I would have disabled it, but it's only a few lines.
True. Those I'll disable.
Yup. On it.
That's a good idea. I'll start a new PR for the CI reduction. |
Test update PR: #4764 |
go.mod: bump osbuild/images to v0.40.1
Update and reduce testing to RHEL 8.10
Reduce test configurations to only run on and for RHEL 8.10 and bump the
terraform commit ID.
Update all GitHub runners to Ubuntu 22.04 (from 20.04, deprecated).
Install dnf4 in the Python Lint job for dnf-json since it runs on Fedora
41 now.
dnf-json,koji-compose: fix linting issues
We're using a newer linter now. Fix up the minor issues in the python
scripts.