Skip to content

[RHEL 8.10] go.mod: bump osbuild/images to v0.40.1 #4759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: rhel-8.10.0
Choose a base branch
from

Conversation

achilleas-k
Copy link
Member

@achilleas-k achilleas-k commented Jun 25, 2025

go.mod: bump osbuild/images to v0.40.1


Update and reduce testing to RHEL 8.10

Reduce test configurations to only run on and for RHEL 8.10 and bump the
terraform commit ID.
Update all GitHub runners to Ubuntu 22.04 (from 20.04, deprecated).

Install dnf4 in the Python Lint job for dnf-json since it runs on Fedora
41 now.


dnf-json,koji-compose: fix linting issues

We're using a newer linter now. Fix up the minor issues in the python
scripts.


@achilleas-k achilleas-k requested a review from a team as a code owner June 25, 2025 17:00
@achilleas-k achilleas-k requested review from mvo5, thozza and supakeen and removed request for a team June 25, 2025 17:00
@achilleas-k achilleas-k changed the base branch from main to rhel-8.10.0 June 25, 2025 17:00
@achilleas-k
Copy link
Member Author

We're going to need more test setup fiddling

@achilleas-k achilleas-k force-pushed the r8.10/bump/images branch 5 times, most recently from 1c50279 to d4111be Compare June 26, 2025 15:19
mvo5
mvo5 previously approved these changes Jun 26, 2025
Copy link
Member

@thozza thozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting the CI work on the rhel-X.Y.0 branches is always soooo painful 😭

My random comments/thoughts:

  • Are changes to tools/koji-compose.py needed when Koji test cases are not run as part of CI? We do not need to test Koji for the 8.10 update at all.
  • The same applies to the Cloud API tests (api.sh) - we don't need to keep testing them.
  • The triggering of nightly tests in .github/workflows/trigger-gitlab.yml needs to be removed.
  • In general, I found it easier to read to have a separate PR to reduce CI and get it working on 8.10, and then have a new PR that does the required changes. This way, we will verify if the update works correctly, as now you risk losing changes to CI that are necessary due to the images update, among other changes.

Reduce test configurations to only run on and for RHEL 8.10 and bump the
terraform commit ID.
Update all GitHub runners to Ubuntu 22.04 (from 20.04, deprecated).

Install dnf4 in the Python Lint job for dnf-json since it runs on Fedora
41 now.
We're using a newer linter now.  Fix up the minor issues in the python
scripts.
@achilleas-k
Copy link
Member Author

  • Are changes to tools/koji-compose.py needed when Koji test cases are not run as part of CI? We do not need to test Koji for the 8.10 update at all.

Not really no. But I had to update the Lint job runner, which updated the linter, which caught issues with the old version of the script. So I decided it's simpler to pull in the new version of the script to make the linter happy rather than disable the check. If the changes were more substantial I would have disabled it, but it's only a few lines.

  • The same applies to the Cloud API tests (api.sh) - we don't need to keep testing them.

True. Those I'll disable.

  • The triggering of nightly tests in .github/workflows/trigger-gitlab.yml needs to be removed.

Yup. On it.

  • In general, I found it easier to read to have a separate PR to reduce CI and get it working on 8.10, and then have a new PR that does the required changes. This way, we will verify if the update works correctly, as now you risk losing changes to CI that are necessary due to the images update, among other changes.

That's a good idea. I'll start a new PR for the CI reduction.

@achilleas-k achilleas-k marked this pull request as draft June 27, 2025 12:46
@achilleas-k
Copy link
Member Author

Test update PR: #4764

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants