commit atm - #140
Open
kerenkay wants to merge 5 commits into
Open
commit atm#140kerenkay wants to merge 5 commits into
kerenkay wants to merge 5 commits into
Conversation
natsala13
requested changes
Apr 6, 2020
jhb1996
reviewed
Apr 6, 2020
IgalKolihman
requested changes
Apr 6, 2020
Collaborator
|
make sure flake 8 pass |
natsala13
requested changes
Apr 6, 2020
rfire01
requested changes
Apr 7, 2020
| with open(filename, 'r') as file: | ||
| for line in file: | ||
| details = line.strip().split(' ') | ||
| atm[details[ID_INDEX]] = details[INDEX_START_OF_PASSWORD_AND_BALANCE:] |
Collaborator
There was a problem hiding this comment.
Saving the data as list isn't a good practice.
What happen if you change the way the data look? you need to change everywhere you use it the indexes of each part.
Instead the only place that should be effect is the read file function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.