Calculator Exercise - #146
Open
yonatanevantal wants to merge 16 commits into
Open
Conversation
rfire01
requested changes
Apr 21, 2020
yairigal
suggested changes
Apr 21, 2020
NivosMagnivos
suggested changes
Apr 22, 2020
jacksonpc2
suggested changes
Apr 23, 2020
Comment on lines
+6
to
+10
| import math | ||
| import operator | ||
| import re | ||
| from collections import namedtuple | ||
| from sys import maxsize |
Comment on lines
+15
to
+16
| # higher precedence means the operator stronger (will be done first) | ||
| Operator = namedtuple("Operator", ["operation", "precedence", "regex"]) |
Comment on lines
+18
to
+46
| OPERATORS = { | ||
| '+': Operator(precedence=1, operation=operator.add, | ||
| regex=fr"({ANY_NUMBER})\+({ANY_NUMBER})"), | ||
| '-': Operator(precedence=1, operation=operator.sub, | ||
| regex=fr"({ANY_NUMBER})-({ANY_NUMBER})"), | ||
|
|
||
| '*': Operator(precedence=2, operation=operator.mul, | ||
| regex=fr"({ANY_NUMBER})\*({ANY_NUMBER})"), | ||
| '/': Operator(precedence=2, operation=operator.truediv, | ||
| regex=fr"({ANY_NUMBER})/({ANY_NUMBER})"), | ||
|
|
||
| '^': Operator(precedence=3, operation=math.pow, | ||
| regex=fr"({ANY_NUMBER})\^({ANY_NUMBER})"), | ||
| '%': Operator(precedence=4, operation=math.fmod, | ||
| regex=fr"({ANY_NUMBER})%({ANY_NUMBER})"), | ||
|
|
||
| '@': Operator(precedence=5, operation=lambda x, y: (x + y) / 2.0, | ||
| regex=fr"({ANY_NUMBER})@({ANY_NUMBER})"), | ||
| '$': Operator(precedence=5, operation=max, | ||
| regex=fr"({ANY_NUMBER})\$({ANY_NUMBER})"), | ||
| '&': Operator(precedence=5, operation=min, | ||
| regex=fr"({ANY_NUMBER})&({ANY_NUMBER})"), | ||
|
|
||
| '~': Operator(precedence=6, operation=operator.neg, | ||
| regex=fr"~({ANY_NUMBER})"), | ||
| '!': Operator(precedence=7, operation=math.factorial, | ||
| regex=fr"({ANY_NUMBER})!"), | ||
|
|
||
| '(': Operator(precedence=maxsize, operation=lambda expr: _evaluate(expr), |
Comment on lines
+51
to
+74
| def operators_info_by_precedence() -> list: | ||
| """Sort the value of each item in OPERATORS by its priority. | ||
|
|
||
| Returns: | ||
| List of Operator named tuples by priority, strong to weak. | ||
| """ | ||
| return sorted(OPERATORS.values(), key=operator.attrgetter("precedence"), | ||
| reverse=True) | ||
|
|
||
|
|
||
| def replace_in_expression(operator_regex: str, expression: str, | ||
| new_expr: str) -> str: | ||
| """Change the old sub expression to a new one according to pattern. | ||
|
|
||
| Args: | ||
| operator_regex: pattern to find a sub expression of the operator. | ||
| expression: the entire expression. | ||
| new_expr: the expression to put instead of the old one. | ||
|
|
||
| Returns: | ||
| A new whole expression, changed according to pattern. | ||
| """ | ||
| old_expression = re.search(operator_regex, expression).group() | ||
| return expression.replace(old_expression, new_expr) |
There was a problem hiding this comment.
Both of this functions seems redundant.
Just inline those lines, its simple enough and clear.
| if operator_info.precedence != maxsize: | ||
| operands = list(map(float, operands)) | ||
|
|
||
| result = operator_info.operation(*operands) |
| operator_regex, expression, str(result)) | ||
|
|
||
| return _evaluate(expression) | ||
| return float(expression) |
Comment on lines
+104
to
+108
| raw_expression = input(USER_MSG) | ||
|
|
||
| while raw_expression.lower() != "quit": | ||
| print(_evaluate(raw_expression)) | ||
| raw_expression = input(USER_MSG) |
|
|
||
|
|
||
| class TestEdgeCases(unittest.TestCase): | ||
| """Test rare cases of inputs to see function behavior""" |
jacksonpc2
suggested changes
Apr 23, 2020
Comment on lines
+55
to
+57
| with self.assertRaises(ValueError): | ||
| _evaluate('1+a*76') | ||
|
|
There was a problem hiding this comment.
Check the output of the expression : -1-2*-2
yairigal
suggested changes
Apr 23, 2020
yairigal
suggested changes
Apr 23, 2020
yairigal
approved these changes
Apr 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.