Avoid to redownload ban, as ban server does not respect If-Modified-Since #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Il faudrait un |
frodrigo
force-pushed
the
ban_modified
branch
from
1a6b187 to
071d9de
Compare
Corrigé |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
La BAN est assez difficile à télécharger et sur l’ensemble de départements il y en a souvent une partie en erreur.
À relancer le téléchargement, le script recommence à tout télécharger car le serveur distant ne respecte pas l'entête HTPP
If-Modified-Since.Cette modif saute le téléchargement quand le serveur répond
HTTP 200mais avec unLast-Modifiedqui n'est pas plus récent.Cela permet de continuer le téléchargement quand on réessaye. (En pratique j’utilise une
parallel --retries 3pour ressaye, mais c’est éventuellement un autre PR.)