github actions: fix setup of PostgreSQL #2306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apt won't set up a database for the differently installed postgresql otherwise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Postgresql's apt repository has slightly changed the setup rules for its postgres packages in Thursday's release: normally the package would automatically set up and start a database, if not exists for the version installed. The new behaviour seems to be to only set up the database if there is no Postgresql database set up at all. This new behaviour makes perfect sense, but breaks CI runs which so far have kept the already installed postgres from the default version around. The version we actually want to test against is not installed anymore. The fix is to purge the default version instead of just removing it.
The PR also switches to the Debian-supplied way of setting up the PostgreSQL apt repository and removes some code for a clang version which has long fallen out of support.