Update analyser_merge_poste_FR : encoding et columns change in data source #2628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Your change map wheelchair None value to no, looks bad to me ? |
Contributor
Author
|
The problem doesn't exist today because this column only contains "Oui" or "Non". It's in other columns where the "No" values have been replaced with blanks, but I modified the code in case blanks appear in this column. |
Contributor
Maby the status was unknown but the file was before filled with "No". And now they fixed it by removing the "No", to let is know that "unknown" ? And so we should do it ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
encoding : now it's utf.
wheelchair : The columns have changed. There are now many columns for disabilities, but all have the same value for wheelchair.
"No" value : "Non" or nothing, depending on the column.