Skip to content

Add full tags to 0.3 issues API JSON response #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

flacombe
Copy link
Contributor

@flacombe flacombe commented Jul 3, 2025

Following discussion, this PR propose to extend the issues API response with not only elems ids but tags as well, just like in the geojson.

Currently stuck in the test because of i18n so it's currently draft

@flacombe
Copy link
Contributor Author

Tests are fine on my local instance.
I've processed osmose_powerline analyser on france_rhone_alpes_haute_savoie and obtained a JSON for class 6, that contains elems/tags in the JSON full output

I recommend merging it after #540

) -> Dict[Literal["issues"], List[Dict[str, Any]]]:
params.limit = min(params.limit, 100000)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You lost the custom max limit.

Copy link
Contributor Author

@flacombe flacombe Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frodrigo
Copy link
Contributor

You add full=true to all the output. But the idea of having a such param is to avoid fetching/send too much data. I am unsure about that.

@flacombe
Copy link
Contributor Author

It was already set to true for any output that relies on _issues():
https://github.com/osmose-qa/osmose-frontend/blob/master/api/issues.py#L245

I set it to true in many outputs because in my PR _issues() could be called with params.full=False

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants