-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Galaxy Station wallet #4040
base: stage
Are you sure you want to change the base?
Conversation
@echel0n-HX is attempting to deploy a commit to the OsmoLabs Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe changes add support for the Galaxy Station wallets by introducing new wallet entries. In the wallet list configuration, two new imports are added and appended to the CosmosKitWalletList, including an override for the mobile wallet’s URL formatting. In the wallet registry, two new wallet configurations are introduced—one for the extension and one for the mobile version—with proper chain support checks and connection URL definitions, including stake and governance URLs. No existing functionalities were removed or modified. Changes
Sequence Diagram(s)sequenceDiagram
participant App as Application
participant Registry as Wallet Registry
participant Extension as Galaxy Station Extension Config
participant Mobile as Galaxy Station Mobile Config
App->>Registry: Request wallet connection
Registry->>Extension: Check extension availability (window.galaxyStation)
alt Extension Present
Extension-->>Registry: Return configuration and chain support
else Mobile:
Registry->>Mobile: Check supported chains list
Mobile->>Mobile: Execute formatNativeUrl override to format URL
Mobile-->>Registry: Return configuration and formatted URL
end
Registry-->>App: Provide wallet connection details
Suggested reviewers
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 ESLint
packages/web/config/generate-cosmos-kit-wallet-list.tsOops! Something went wrong! :( ESLint: 8.50.0 ESLint couldn't find the config "next/core-web-vitals" to extend from. Please check that the name of the config is correct. The config "next/core-web-vitals" was referenced from the config file in "/packages/web/.eslintrc.json". If you still have problems, please stop by https://eslint.org/chat/help to chat with the team. packages/web/config/wallet-registry.tsOops! Something went wrong! :( ESLint: 8.50.0 ESLint couldn't find the config "next/core-web-vitals" to extend from. Please check that the name of the config is correct. The config "next/core-web-vitals" was referenced from the config file in "/packages/web/.eslintrc.json". If you still have problems, please stop by https://eslint.org/chat/help to chat with the team. ✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/web/config/wallet-registry.ts (1)
365-418
: Consider sorting the chain list alphabetically.The mobile wallet configuration is correct, but the
galaxyStationMobileAvailableChains
array could be sorted alphabetically for better maintainability.Apply this diff to sort the chains:
const galaxyStationMobileAvailableChains: MainnetChainIds[] = [ "akashnet-2", "archway-1", "atomone-1", "bitsong-2b", "carbon-1", "celestia", "cheqd-mainnet-1", "chihuahua-1", "columbus-5", "comdex-1", "cosmoshub-4", "crescent-1", "dydx-mainnet-1", "gravity-bridge-3", "injective-1", "irishub-1", "juno-1", "kaiyo-1", "kava_2222-10", "kichain-2", "lum-network-1", - "mars-1", "mainnet-3", + "mars-1", "migaloo-1", "neutron-1", "noble-1", "osmosis-1", - "ssc-1", "pacific-1", "phoenix-1", "sentinelhub-2", + "ssc-1", "stafihub-1", "stargaze-1", "stride-1", "teritori-1", ];
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (3)
packages/web/package.json
is excluded by!**/*.json
packages/web/public/wallets/galaxy-station.png
is excluded by!**/*.png
,!**/*.png
yarn.lock
is excluded by!**/yarn.lock
,!**/*.lock
,!**/*.lock
📒 Files selected for processing (2)
packages/web/config/generate-cosmos-kit-wallet-list.ts
(3 hunks)packages/web/config/wallet-registry.ts
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Summary
🔇 Additional comments (3)
packages/web/config/generate-cosmos-kit-wallet-list.ts (2)
8-9
: LGTM! Galaxy Station wallets correctly imported and added to the wallet list.The Galaxy Station extension and mobile wallets are properly imported and integrated into the
CosmosKitWalletList
.Also applies to: 43-44
103-114
: LGTM! Mobile wallet URL formatting properly configured.The
formatNativeUrl
override for Galaxy Station mobile wallet correctly implements the required URL format using HTTPS.packages/web/config/wallet-registry.ts (1)
339-364
: LGTM! Galaxy Station extension wallet properly configured.The extension wallet configuration follows best practices with proper chain support verification and secure URLs.
What is the purpose of the change:
Add support for Galaxy Station extension and mobile