Update README.md so docker run downloads from ghcr #9881
Conversation
docker run cmd now uses complete tag to enable download from ghcr Signed-off-by: hartmutobendorf <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9881 +/- ##
=========================================
Coverage 68.21% 68.21%
Complexity 1293 1293
=========================================
Files 250 250
Lines 8849 8849
Branches 920 920
=========================================
Hits 6036 6036
Misses 2424 2424
Partials 389 389
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@hartmutobendorf, please have a look at the failing check. We require conventional commits. Just take a look at the commit history for examples. |
| @@ -124,7 +124,7 @@ Depending on how ORT was installed, it can be run in the following ways: | |||
| * If the Docker image was built, use | |||
|
|
|||
| ```shell | |||
| docker run ort --help | |||
| docker run ghcr.io/oss-review-toolkit/ort --help | |||
There was a problem hiding this comment.
In line 109 there are the build instructions which use ort as the image tag, which was used by the previous version of the command. Do we need any alignment?
There was a problem hiding this comment.
Actually, the list item title in line 124 says "If the Docker image was built" (i.e. it was built locally by the user), so I believe the change to be invalid and be caused by a misunderstanding that these are not usage instructions for the case when a published image is downloaded from the Docker registry.
What do you think, @mnonnenmacher, as you where mentioning this stale PR in today's meeting?
|
@hartmutobendorf, are you planning to follow-up here? |
docker run cmd now uses complete tag to enable download from ghcr