Open
Conversation
…efactored try_query
…_logic, deleted build_family_where_test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #283
Refactored build_where_text to use the psycopg2.sql module, refactored the rest of the functions to use the new logic, deleted build_family_where_text, created apply_filter_logic function to format filters correctly and create SQL statement for the filter. This function allows us to build queries using SQL, Identifier, and Placeholder objects, ensuring that table names, column names, and values are handled safely by the driver.
Issue #286
Rebuilt a custom version of the DictCursor code in postgres_connector, using only Python primitives (no additional libraries). Created a new function rows_to_dicts which takes the results from a database search and turns them into a list of labeled dictionaries so the data is easier to read and use. Refactored try_query to use this new function instead of DictCursor.