Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rtmp2rtc: Support HEVC #4289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
rtmp2rtc: Support HEVC #4289
Changes from all commits
1a224c7
b3c5085
83d577a
c11afbe
83e8877
8953dbf
c2e31d1
6363ed3
4733e7f
4a1c409
49cc599
7441864
8a9e7ae
e8a5e3e
ea0d230
33b2401
a7cb838
9e6fd12
a33aa59
f009cc3
dc4acb5
571094e
fb6a88c
3e57f77
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a so general method, the
profile-id
defined in h.265 standard, but just main profile(1), main 10 profile(2), and main still picture profile(3) are commonly used.why not add more specific wrapper method. e.g.
srs_sdp_has_h265_main_profile(const SrsSdp& sdp)
,srs_sdp_has_h265_main_10_profile(sdp)
andsrs_sdp_has_h265_main_still_picture_profile(sdp)
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To align with H264, and we can improve it in another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is C98 incompatible?
TRANS_BY_GPT4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compatibility