Skip to content

rtmp2rtc: Support HEVC #4289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 24 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
1a224c7
rtmp2rtc: support hevc
duiniuluantanqin Feb 16, 2025
b3c5085
remove unused code
duiniuluantanqin Feb 19, 2025
83d577a
define SrsAvcNaluTypeParse
duiniuluantanqin Feb 19, 2025
c11afbe
Merge branch 'develop' into hevc_over_rtc
duiniuluantanqin Feb 20, 2025
83e8877
Merge branch 'develop' into hevc_over_rtc
duiniuluantanqin Feb 20, 2025
8953dbf
Optimize init h265 track and format.
chundonglinlin Feb 21, 2025
c2e31d1
Modify the play stream to specify encoding format.
chundonglinlin Feb 22, 2025
6363ed3
Fix HLS logging error
duiniuluantanqin Feb 24, 2025
4733e7f
Fix HEVC STAP payload decoding in RTP
duiniuluantanqin Feb 24, 2025
4a1c409
prevent memory leaks
duiniuluantanqin Mar 4, 2025
49cc599
update Update the page numbers
duiniuluantanqin Mar 17, 2025
7441864
Merge branch 'develop' into hevc_over_rtc
duiniuluantanqin Mar 18, 2025
8a9e7ae
check pointer
duiniuluantanqin Mar 18, 2025
e8a5e3e
fix compile warn
duiniuluantanqin Mar 18, 2025
ea0d230
add SrsRtspPacketPayloadTypeFUAHevc2
duiniuluantanqin Mar 19, 2025
33b2401
add utest: VideoFrame
duiniuluantanqin Mar 19, 2025
a7cb838
move to another pull request.
duiniuluantanqin Mar 20, 2025
9e6fd12
use c++03 style
duiniuluantanqin Mar 21, 2025
a33aa59
Update AVC frame parsing logic to correctly identify IDR, SPS, and PP…
duiniuluantanqin Mar 21, 2025
f009cc3
Merge branch 'develop' into hevc_over_rtc
duiniuluantanqin Mar 21, 2025
dc4acb5
rename `parse_avc_b_frame` and `parse_hevc_b_frame` to `parse_avc_bfr…
duiniuluantanqin Apr 4, 2025
571094e
Merge branch 'develop' into hevc_over_rtc
duiniuluantanqin Apr 6, 2025
fb6a88c
Merge branch 'develop' into hevc_over_rtc
duiniuluantanqin Apr 17, 2025
3e57f77
Merge branch 'develop' into hevc_over_rtc
duiniuluantanqin Apr 27, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion trunk/src/app/srs_app_hls.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1068,7 +1068,7 @@ srs_error_t SrsHlsController::write_video(SrsVideoFrame* frame, int64_t dts)

// Refresh the codec ASAP.
if (muxer->latest_vcodec() != frame->vcodec()->id) {
srs_trace("HLS: Switch video codec %d(%s) to %d(%s)", muxer->latest_acodec(), srs_video_codec_id2str(muxer->latest_vcodec()).c_str(),
srs_trace("HLS: Switch video codec %d(%s) to %d(%s)", muxer->latest_vcodec(), srs_video_codec_id2str(muxer->latest_vcodec()).c_str(),
frame->vcodec()->id, srs_video_codec_id2str(frame->vcodec()->id).c_str());
muxer->set_latest_vcodec(frame->vcodec()->id);
}
Expand Down
166 changes: 122 additions & 44 deletions trunk/src/app/srs_app_rtc_conn.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2598,6 +2598,51 @@ bool srs_sdp_has_h264_profile(const SrsSdp& sdp, const string& profile)
return false;
}

bool srs_sdp_has_h265_profile(const SrsMediaPayloadType& payload_type, const string& profile)
{
srs_error_t err = srs_success;

if (payload_type.format_specific_param_.empty()) {
return false;
}

H265SpecificParam h265_param;
if ((err = srs_parse_h265_fmtp(payload_type.format_specific_param_, h265_param)) != srs_success) {
srs_error_reset(err);
return false;
}

if (h265_param.profile_id == profile) {
return true;
}

return false;
}

bool srs_sdp_has_h265_profile(const SrsSdp& sdp, const string& profile)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a so general method, the profile-id defined in h.265 standard, but just main profile(1), main 10 profile(2), and main still picture profile(3) are commonly used.

why not add more specific wrapper method. e.g. srs_sdp_has_h265_main_profile(const SrsSdp& sdp),
srs_sdp_has_h265_main_10_profile(sdp) and srs_sdp_has_h265_main_still_picture_profile(sdp).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To align with H264, and we can improve it in another PR.

{
for (size_t i = 0; i < sdp.media_descs_.size(); ++i) {
const SrsMediaDesc& desc = sdp.media_descs_[i];
if (!desc.is_video()) {
continue;
}

std::vector<SrsMediaPayloadType> payloads = desc.find_media_with_encoding_name("H265");
if (payloads.empty()) {
continue;
}

for (std::vector<SrsMediaPayloadType>::iterator it = payloads.begin(); it != payloads.end(); ++it) {
const SrsMediaPayloadType& payload_type = *it;
if (srs_sdp_has_h265_profile(payload_type, profile)) {
return true;
}
}
}

return false;
}

srs_error_t SrsRtcConnection::negotiate_publish_capability(SrsRtcUserConfig* ruc, SrsRtcSourceDescription* stream_desc)
{
srs_error_t err = srs_success;
Expand Down Expand Up @@ -3041,8 +3086,6 @@ srs_error_t SrsRtcConnection::negotiate_play_capability(SrsRtcUserConfig* ruc, s

bool nack_enabled = _srs_config->get_rtc_nack_enabled(req->vhost);
bool twcc_enabled = _srs_config->get_rtc_twcc_enabled(req->vhost);
// TODO: FIME: Should check packetization-mode=1 also.
bool has_42e01f = srs_sdp_has_h264_profile(remote_sdp, "42e01f");

SrsSharedPtr<SrsRtcSource> source;
if ((err = _srs_rtc_sources->fetch_or_create(req, source)) != srs_success) {
Expand Down Expand Up @@ -3083,56 +3126,87 @@ srs_error_t SrsRtcConnection::negotiate_play_capability(SrsRtcUserConfig* ruc, s

remote_payload = payloads.at(0);
track_descs = source->get_track_desc("audio", "opus");
} else if (remote_media_desc.is_video() && ruc->codec_ == "av1") {
std::vector<SrsMediaPayloadType> payloads = remote_media_desc.find_media_with_encoding_name("AV1");
if (payloads.empty()) {
// Be compatible with the Chrome M96, still check the AV1X encoding name
// @see https://bugs.chromium.org/p/webrtc/issues/detail?id=13166
payloads = remote_media_desc.find_media_with_encoding_name("AV1X");
}
if (payloads.empty()) {
return srs_error_new(ERROR_RTC_SDP_EXCHANGE, "no found valid AV1 payload type");
} else if (remote_media_desc.is_video()) {
std::string prefer_codec = ruc->codec_;
if (prefer_codec.empty()) {
// Get the source codec if not specified.
std::vector<SrsRtcTrackDescription*> track_descs = source->get_track_desc("video", "");
if (!track_descs.empty()) {
std::string codec_name = track_descs.at(0)->media_->name_;
std::transform(codec_name.begin(), codec_name.end(), codec_name.begin(), ::tolower);
Copy link
Collaborator

@xiaozhihong xiaozhihong Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is C98 incompatible?

TRANS_BY_GPT4

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compatibility

if (codec_name == "h265") {
prefer_codec = "hevc";
} else {
prefer_codec = codec_name;
}
} else {
return srs_error_new(ERROR_RTC_SDP_EXCHANGE, "no video track in source");
}
}

remote_payload = payloads.at(0);
track_descs = source->get_track_desc("video", "AV1");
if (track_descs.empty()) {
// Be compatible with the Chrome M96, still check the AV1X encoding name
// @see https://bugs.chromium.org/p/webrtc/issues/detail?id=13166
track_descs = source->get_track_desc("video", "AV1X");
}
} else if (remote_media_desc.is_video() && ruc->codec_ == "hevc") {
std::vector<SrsMediaPayloadType> payloads = remote_media_desc.find_media_with_encoding_name("H265");
if (payloads.empty()) {
return srs_error_new(ERROR_RTC_SDP_EXCHANGE, "no valid found h265 payload type");
}
if (prefer_codec == "av1") {
std::vector<SrsMediaPayloadType> payloads = remote_media_desc.find_media_with_encoding_name("AV1");
if (payloads.empty()) {
// Be compatible with the Chrome M96, still check the AV1X encoding name
// @see https://bugs.chromium.org/p/webrtc/issues/detail?id=13166
payloads = remote_media_desc.find_media_with_encoding_name("AV1X");
}
if (payloads.empty()) {
return srs_error_new(ERROR_RTC_SDP_EXCHANGE, "no found valid AV1 payload type");
}

remote_payload = payloads.at(0);
remote_payload = payloads.at(0);
track_descs = source->get_track_desc("video", "AV1");
if (track_descs.empty()) {
// Be compatible with the Chrome M96, still check the AV1X encoding name
// @see https://bugs.chromium.org/p/webrtc/issues/detail?id=13166
track_descs = source->get_track_desc("video", "AV1X");
}
} else if (prefer_codec == "hevc") {
std::vector<SrsMediaPayloadType> payloads = remote_media_desc.find_media_with_encoding_name("H265");
if (payloads.empty()) {
return srs_error_new(ERROR_RTC_SDP_EXCHANGE, "no valid found h265 payload type");
}

// @see https://www.rfc-editor.org/rfc/rfc7798#section-7.2.1
bool has_main_profile = srs_sdp_has_h265_profile(remote_sdp, "1");
remote_payload = payloads.at(0);

for (int j = 0; j < (int)payloads.size(); j++) {
const SrsMediaPayloadType& payload = payloads.at(j);

// For H.265, we only check if profile-id=1 (Main Profile)
// Format example: level-id=180;profile-id=1;tier-flag=0;tx-mode=SRST
if (!has_main_profile || srs_sdp_has_h265_profile(payload, "1")) {
remote_payload = payload;
break;
}
}

// TODO: FIXME: pick up a profile for HEVC.
// @see https://www.rfc-editor.org/rfc/rfc7798#section-7.2.1
track_descs = source->get_track_desc("video", "H265");
} else {
vector<SrsMediaPayloadType> payloads = remote_media_desc.find_media_with_encoding_name("H264");
if (payloads.empty()) {
return srs_error_new(ERROR_RTC_SDP_EXCHANGE, "no valid found h264 payload type");
}

track_descs = source->get_track_desc("video", "H265");
} else if (remote_media_desc.is_video()) {
// TODO: check opus format specific param
vector<SrsMediaPayloadType> payloads = remote_media_desc.find_media_with_encoding_name("H264");
if (payloads.empty()) {
return srs_error_new(ERROR_RTC_SDP_EXCHANGE, "no valid found h264 payload type");
}
// TODO: FIME: Should check packetization-mode=1 also.
bool has_42e01f = srs_sdp_has_h264_profile(remote_sdp, "42e01f");

remote_payload = payloads.at(0);
for (int j = 0; j < (int)payloads.size(); j++) {
const SrsMediaPayloadType& payload = payloads.at(j);
remote_payload = payloads.at(0);
for (int j = 0; j < (int)payloads.size(); j++) {
const SrsMediaPayloadType& payload = payloads.at(j);

// If exists 42e01f profile, choose it; otherwise, use the first payload.
// TODO: FIME: Should check packetization-mode=1 also.
if (!has_42e01f || srs_sdp_has_h264_profile(payload, "42e01f")) {
remote_payload = payload;
break;
// If exists 42e01f profile, choose it; otherwise, use the first payload.
// TODO: FIME: Should check packetization-mode=1 also.
if (!has_42e01f || srs_sdp_has_h264_profile(payload, "42e01f")) {
remote_payload = payload;
break;
}
}
}

track_descs = source->get_track_desc("video", "H264");
track_descs = source->get_track_desc("video", "H264");
}
}

for (int j = 0; j < (int)track_descs.size(); ++j) {
Expand Down Expand Up @@ -3238,7 +3312,11 @@ void video_track_generate_play_offer(SrsRtcTrackDescription* track, string mid,

SrsVideoPayload* payload = (SrsVideoPayload*)track->media_;

local_media_desc.payload_types_.push_back(payload->generate_media_payload_type());
if (payload->name_ == "H265") {
local_media_desc.payload_types_.push_back(payload->generate_media_payload_type_h265());
} else {
local_media_desc.payload_types_.push_back(payload->generate_media_payload_type());
}

if (track->red_) {
SrsRedPayload* red_payload = (SrsRedPayload*)track->red_;
Expand Down
36 changes: 36 additions & 0 deletions trunk/src/app/srs_app_rtc_sdp.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,42 @@ srs_error_t srs_parse_h264_fmtp(const std::string& fmtp, H264SpecificParam& h264
return err;
}

srs_error_t srs_parse_h265_fmtp(const std::string& fmtp, H265SpecificParam& h265_param)
{
srs_error_t err = srs_success;

std::vector<std::string> vec = srs_string_split(fmtp, ";");
for (size_t i = 0; i < vec.size(); ++i) {
std::vector<std::string> kv = srs_string_split(vec[i], "=");
if (kv.size() != 2) continue;

if (kv[0] == "level-id") {
h265_param.level_id = kv[1];
} else if (kv[0] == "profile-id") {
h265_param.profile_id = kv[1];
} else if (kv[0] == "tier-flag") {
h265_param.tier_flag = kv[1];
} else if (kv[0] == "tx-mode") {
h265_param.tx_mode = kv[1];
}
}

if (h265_param.level_id.empty()) {
return srs_error_new(ERROR_RTC_SDP_DECODE, "no h265 param: level-id");
}
if (h265_param.profile_id.empty()) {
return srs_error_new(ERROR_RTC_SDP_DECODE, "no h265 param: profile-id");
}
if (h265_param.tier_flag.empty()) {
return srs_error_new(ERROR_RTC_SDP_DECODE, "no h265 param: tier-flag");
}
if (h265_param.tx_mode.empty()) {
return srs_error_new(ERROR_RTC_SDP_DECODE, "no h265 param: tx-mode");
}

return err;
}

SrsSessionInfo::SrsSessionInfo()
{
}
Expand Down
10 changes: 9 additions & 1 deletion trunk/src/app/srs_app_rtc_sdp.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,16 @@ struct H264SpecificParam
std::string level_asymmerty_allow;
};

extern srs_error_t srs_parse_h264_fmtp(const std::string& fmtp, H264SpecificParam& h264_param);
struct H265SpecificParam
{
std::string level_id;
std::string profile_id;
std::string tier_flag;
std::string tx_mode;
};

extern srs_error_t srs_parse_h264_fmtp(const std::string& fmtp, H264SpecificParam& h264_param);
extern srs_error_t srs_parse_h265_fmtp(const std::string& fmtp, H265SpecificParam& h265_param);
class SrsMediaPayloadType
{
public:
Expand Down
Loading
Loading