Add feature to export and import options file #553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rian8337
approved these changes
Jun 28, 2025
|
|
||
| public class ConfigBackup { | ||
|
|
||
| private static final Set<String> EXCLUDE_KEYS = Set.of("installID", "onlineUsername", "onlinePassword"); |
There was a problem hiding this comment.
We really need a single source of truth for preference keys (i.e., an enum) sooner than later to avoid having these all over the place...
There was a problem hiding this comment.
Kinda late but "version" is also a key that should be ignored, for more information check UpdateManager.
There was a problem hiding this comment.
Kinda late but "version" is also a key that should be ignored, for more information check UpdateManager.
Ah, I completely missed that
There was a problem hiding this comment.
The key doesn't seem to be included on the exported options file but I'll add it as an exclude, just in case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested it and it's working fine.
This also excludes sensitive preferences:
installID,onlineUsernameandonlinePasswordDev build can be downloaded and tested from https://github.com/kairusds/osu-droid/releases/tag/dev1