Skip to content

feat: add support for {composer} tag with smart path formatting#324

Merged
moddroid94 merged 3 commits into
ots-downloader:search-filter-fixfrom
edisun3003:master
Jun 15, 2026
Merged

feat: add support for {composer} tag with smart path formatting#324
moddroid94 merged 3 commits into
ots-downloader:search-filter-fixfrom
edisun3003:master

Conversation

@edisun3003

@edisun3003 edisun3003 commented Jun 3, 2026

Copy link
Copy Markdown

Pull Request Description: Add {composer} Tag Support

Title: feat: Add {composer} tag support with smart path formatting

Description

This PR adds support for a {composer} variable in the track path formatter and metadata embedding.

Why this is needed (The Tamil Music/Apple Music Problem)

When downloading soundtracks—specifically Tamil movie songs from Apple Music—the Album Artist tag is often inconsistent or missing, while the Composer field is almost always populated with the primary music director (e.g., A.R. Rahman, Anirudh).

Currently, users have to rely on {artist}, which can lead to fragmented folder structures if multiple artists are featured on a track. By adding {composer}, users can reliably organize their library by the actual music director.

Key Changes

  1. Metadata Extraction: Added explicit extraction of composerName for Apple Music and writers for Spotify credits.
  2. Smart Path Formatting: Added a logic refinement for the {composer} path variable. If the composer field contains multiple names (e.g., A.R. Rahman & Na. Muthukumar), the path formatter will only use the first name for the folder structure to keep libraries clean.
  3. Full Metadata Preservation: While the folder path uses the primary name, the full list of names is still embedded into the file's internal metadata tags (mapping to TCOM for MP3/ID3).
  4. Configuration: Added an embed_composer toggle in the settings.

Verification Results

  • Tested with Apple Music URLs.
  • Verified that Tracks/{composer}/{album}/ correctly creates folders using only the lead composer's name.
  • Verified that ID3 tags correctly contain the full composer string via MP3Tag/ffprobe.

@edisun3003 edisun3003 closed this Jun 3, 2026
@github-project-automation github-project-automation Bot moved this from Todo to Done in OnTheSpot Board Jun 3, 2026
@edisun3003 edisun3003 reopened this Jun 3, 2026
@moddroid94 moddroid94 moved this from Done to Todo in OnTheSpot Board Jun 4, 2026
Signed-off-by: 0x4B1D <ilsecco94@gmail.com>
@moddroid94

Copy link
Copy Markdown
Collaborator

i'm not really sure how this could help given the state of the app, but it's a simple change, but we should add a toggle in the ui, it's not going to pick it up automatically i think.

@edisun3003

Copy link
Copy Markdown
Author

toggle keys are added in settings and it s functioning in my build

@moddroid94

Copy link
Copy Markdown
Collaborator

toggle keys are added in settings and it s functioning in my build

oh, ok.

i thought they had to be added to the .ui file, my bad.

but i didn't saw you pushed to master, which is quite behind the search-filter-fix branch where the latest development is happening, unfortunately both me and justin are quite busy and the spotify/tidal ecc landscape changes too quick to follow with all the patches, so the project it's mostly stale for now, if you can change the target to the filter fix i can merge it no problem, otherwise i'll try to do it myself this weekend.

cheers

@moddroid94 moddroid94 changed the base branch from master to search-filter-fix June 15, 2026 16:23
@moddroid94 moddroid94 merged commit 1efab5c into ots-downloader:search-filter-fix Jun 15, 2026
@github-project-automation github-project-automation Bot moved this from Todo to Done in OnTheSpot Board Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants