add support to launch mssql instance #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Odonno
reviewed
Sep 8, 2025
| </DropdownMenuItem> | ||
| <DropdownMenuItem onClick={() => navigate("/instance/create/mssql")}> | ||
| <PostgreIcon className="h-4 w-4" /> | ||
| Microsoft SQL |
There was a problem hiding this comment.
suggestion: I would go for Microsoft SQL Server or simply SQL Server
| export function SqlServerInstance() { | ||
| const [data, setData] = useImmer<DatabaseInstanceStoreItem>(() => ({ | ||
| id: "mssql-" + DatabaseManagerStore.generateShortId(), | ||
| name: "MS SSQL Local", |
There was a problem hiding this comment.
Suggested change
| name: "MS SSQL Local", | |
| name: "SQL Server LocalDb", |
| <div> | ||
| <Toolbar> | ||
| <ToolbarBackButton /> | ||
| <ToolbarTitle text="Create PostgresSQL Database" icon={MySQLIcon} /> |
There was a problem hiding this comment.
Suggested change
| <ToolbarTitle text="Create PostgresSQL Database" icon={MySQLIcon} /> | |
| <ToolbarTitle text="Create MS SQL Database" icon={MySQLIcon} /> |
| PostgreSQL | ||
| </DropdownMenuItem> | ||
| <DropdownMenuItem onClick={() => navigate("/instance/create/mssql")}> | ||
| <PostgreIcon className="h-4 w-4" /> |
There was a problem hiding this comment.
suggestion: not sure if it will help you, but there are some icons here https://react-icons.github.io/react-icons/search/#q=sql
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.