Skip to content

Swift: Add Sendable #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thomasameisel wants to merge 6 commits into
base: ms-master
Choose a base branch
from
Open

Swift: Add Sendable #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c129081
update thrift to add sendable
Jan 28, 2026
8e16925
unused variable
Jan 28, 2026
8323e46
unused
Jan 28, 2026
6e13053
unused
Jan 28, 2026
e5c50c0
unused
Jan 28, 2026
4f88f11
add sendable to telemetryobject
thomasameisel Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions compiler/cpp/src/thrift/generate/t_erl_generator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,6 @@ void t_erl_generator::close_generator() {
}

void t_erl_generator::generate_type_metadata(std::string function_name, vector<string> names) {
vector<string>::iterator s_iter;
size_t num_structs = names.size();

indent(f_types_file_) << function_name << "() ->\n";
Expand Down Expand Up @@ -915,7 +914,6 @@ void t_erl_generator::generate_service(t_service* tservice) {
void t_erl_generator::generate_service_metadata(t_service* tservice) {
export_string("function_names", 0);
vector<t_function*> functions = tservice->get_functions();
vector<t_function*>::iterator f_iter;
size_t num_functions = functions.size();

indent(f_service_) << "function_names() -> " << endl;
Expand Down
3 changes: 0 additions & 3 deletions compiler/cpp/src/thrift/generate/t_go_generator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2100,7 +2100,6 @@ void t_go_generator::generate_service_remote(t_service* tservice) {
<< (*f_iter)->get_name() << "(";
t_struct* arg_struct = (*f_iter)->get_arglist();
const std::vector<t_field*>& args = arg_struct->get_members();
vector<t_field*>::const_iterator a_iter;
std::vector<t_field*>::size_type num_args = args.size();
bool first = true;

Expand Down Expand Up @@ -2229,7 +2228,6 @@ void t_go_generator::generate_service_remote(t_service* tservice) {
for (f_iter = functions.begin(); f_iter != functions.end(); ++f_iter) {
t_struct* arg_struct = (*f_iter)->get_arglist();
const std::vector<t_field*>& args = arg_struct->get_members();
vector<t_field*>::const_iterator a_iter;
std::vector<t_field*>::size_type num_args = args.size();
string funcName((*f_iter)->get_name());
string pubName(publicize(funcName));
Expand Down Expand Up @@ -2614,7 +2612,6 @@ void t_go_generator::generate_process_function(t_service* tservice, t_function*

// t_struct* xs = tfunction->get_xceptions();
// const std::vector<t_field*>& xceptions = xs->get_members();
vector<t_field*>::const_iterator x_iter;
f_types_ << indent() << "type " << processorName << " struct {" << endl;
f_types_ << indent() << " handler " << publicize(tservice->get_name()) << endl;
f_types_ << indent() << "}" << endl << endl;
Expand Down
4 changes: 0 additions & 4 deletions compiler/cpp/src/thrift/generate/t_hs_generator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,7 +590,6 @@ void t_hs_generator::generate_hs_struct_arbitrary(ofstream& out, t_struct* tstru
string tname = type_name(tstruct);
string name = tstruct->get_name();
const vector<t_field*>& members = tstruct->get_members();
vector<t_field*>::const_iterator m_iter;

indent(out) << "instance QC.Arbitrary " << tname << " where " << endl;
indent_up();
Expand Down Expand Up @@ -654,7 +653,6 @@ void t_hs_generator::generate_hs_struct_arbitrary(ofstream& out, t_struct* tstru
*/
void t_hs_generator::generate_hs_struct_reader(ofstream& out, t_struct* tstruct) {
const vector<t_field*>& fields = tstruct->get_members();
vector<t_field*>::const_iterator f_iter;

string sname = type_name(tstruct);
string id = tmp("_id");
Expand Down Expand Up @@ -725,7 +723,6 @@ void t_hs_generator::generate_hs_struct_reader(ofstream& out, t_struct* tstruct)
void t_hs_generator::generate_hs_struct_writer(ofstream& out, t_struct* tstruct) {
string name = type_name(tstruct);
const vector<t_field*>& fields = tstruct->get_sorted_members();
vector<t_field*>::const_iterator f_iter;
string str = tmp("_str");
string f = tmp("_f");
string v = tmp("_v");
Expand Down Expand Up @@ -909,7 +906,6 @@ void t_hs_generator::generate_hs_function_helpers(t_function* tfunction) {
void t_hs_generator::generate_hs_typemap(ofstream& out, t_struct* tstruct) {
string name = type_name(tstruct);
const vector<t_field*>& fields = tstruct->get_sorted_members();
vector<t_field*>::const_iterator f_iter;

indent(out) << "typemap_" << name << " :: T.TypeMap" << endl;
indent(out) << "typemap_" << name << " = Map.fromList [";
Expand Down
2 changes: 0 additions & 2 deletions compiler/cpp/src/thrift/generate/t_py_generator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1600,7 +1600,6 @@ void t_py_generator::generate_service_remote(t_service* tservice) {
<< (*f_iter)->get_name() << "(";
t_struct* arg_struct = (*f_iter)->get_arglist();
const std::vector<t_field*>& args = arg_struct->get_members();
vector<t_field*>::const_iterator a_iter;
std::vector<t_field*>::size_type num_args = args.size();
bool first = true;
for (std::vector<t_field*>::size_type i = 0; i < num_args; ++i) {
Expand Down Expand Up @@ -1706,7 +1705,6 @@ void t_py_generator::generate_service_remote(t_service* tservice) {

t_struct* arg_struct = (*f_iter)->get_arglist();
const std::vector<t_field*>& args = arg_struct->get_members();
vector<t_field*>::const_iterator a_iter;
std::vector<t_field*>::size_type num_args = args.size();

f_remote << "if cmd == '" << (*f_iter)->get_name() << "':" << endl;
Expand Down
9 changes: 6 additions & 3 deletions compiler/cpp/src/thrift/generate/t_swift_generator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ string t_swift_generator::telemetry_object_protocols() {
return R"objc(
public typealias TelemetryDictionary = [String: TelemetryValue]

public protocol TelemetryObject {
public protocol TelemetryObject: Sendable {
func telemetryDictionary() -> TelemetryDictionary
}

Expand Down Expand Up @@ -440,7 +440,7 @@ void t_swift_generator::generate_enum(t_enum* tenum) {
void t_swift_generator::generate_enum(ofstream& f_enum_decl, ofstream& f_enum_impl, t_enum* tenum) {
print_doc(f_enum_decl, tenum, false);

f_enum_decl << indent() << "public enum " << tenum->get_name() << " : Int32";
f_enum_decl << indent() << "public enum " << tenum->get_name() << " : Int, Sendable";
block_open(f_enum_decl);

vector<t_enum_value*> constants = tenum->get_constants();
Expand Down Expand Up @@ -596,7 +596,10 @@ void t_swift_generator::generate_swift_struct(ofstream& out,
out << indent() << visibility << " " << object_type << " " << tstruct->get_name();

if (tstruct->is_xception()) {
out << " : ErrorType";
out << " : ErrorType, @unchecked Sendable";
}
else {
out << " : @unchecked Sendable";
}

block_open(out);
Expand Down
Loading