Skip to content

MULTIARCH-5405: use hostmount-anyuid-v2 SCC for ppc if cluster version >= 4.19 #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 19, 2025
Merged

MULTIARCH-5405: use hostmount-anyuid-v2 SCC for ppc if cluster version >= 4.19 #604

merged 3 commits into from
May 19, 2025

Conversation

@lwan-wanglin
Copy link
Member

thehostmount-anyuid scc hits some permission issue to mount some restricted hostpath, after this pr merged, the ppc pod can't mount /etc/docker/ folder anymore, kube-apiserver introduces a new scc hostmount-anyuid-v2 from 4.19, so,
This PR implements the following:

  • set default requiredSCCHostmoundAnyUID=hostmount-anyuid-v2
  • if cluster minor version < 19(or k8s server minor vesion < 32), use hostmount-anyuid.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 7, 2025
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 7, 2025 •
edited by openshift-ci bot
Loading

@lwan-wanglin: This pull request references MULTIARCH-5405 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

thehostmount-anyuid scc hits some permission issue to mount some restricted hostpath, after this pr merged, the ppc pod can't mount /etc/docker/ folder anymore, kube-apiserver introduces a new scc hostmount-anyuid-v2 from 4.19, so,
This PR implements the following:

  • set default requiredSCCHostmoundAnyUID=hostmount-anyuid-v2
  • if cluster minor version < 19(or k8s server minor vesion < 32), use hostmount-anyuid.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from AnnaZivkovic and aleskandro May 7, 2025 07:53
aleskandro
aleskandro reviewed May 7, 2025
View reviewed changes
aleskandro
aleskandro reviewed May 7, 2025
View reviewed changes
aleskandro
aleskandro reviewed May 7, 2025
View reviewed changes
aleskandro
aleskandro reviewed May 7, 2025
View reviewed changes
aleskandro
aleskandro reviewed May 7, 2025
View reviewed changes
@aleskandro
Copy link
Member

blocked by openshift/cluster-kube-apiserver-operator#1834

@aleskandro
Copy link
Member

aleskandro commented May 7, 2025 •
edited
Loading

/hold

(if openshift/cluster-kube-apiserver-operator#1834 doesn't merge within this week, we can unhold).

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2025
aleskandro
aleskandro reviewed May 8, 2025
View reviewed changes
aleskandro
aleskandro reviewed May 8, 2025
View reviewed changes
aleskandro
aleskandro approved these changes May 9, 2025
View reviewed changes
Copy link
Member

@aleskandro aleskandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2025
@openshift-ci
Copy link

openshift-ci bot commented May 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aleskandro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2025
@aleskandro
Copy link
Member

/cherry-pick v1.x

@openshift-cherrypick-robot
Copy link

@aleskandro: once the present PR merges, I will cherry-pick it on top of v1.x in a new PR and assign it to you.

In response to this:

/cherry-pick v1.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 12, 2025
@lwan-wanglin
Copy link
Member Author

/test ci-index-multiarch-tuning-operator-bundle

@AnnaZivkovic
Copy link
Member

/test ci/prow/ocp419-e2e-gcp

@openshift-ci
Copy link

openshift-ci bot commented May 16, 2025

@AnnaZivkovic: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test bundle

/test ci-index-multiarch-tuning-operator-bundle

/test fmt

/test generate

/test goimports

/test images

/test images-multi

/test lint

/test manifests

/test ocp416-ci-index-multiarch-tuning-operator-bundle

/test ocp416-e2e-gcp

/test ocp416-images

/test ocp417-ci-index-multiarch-tuning-operator-bundle

/test ocp417-e2e-gcp

/test ocp417-images

/test ocp418-ci-index-multiarch-tuning-operator-bundle

/test ocp418-e2e-gcp

/test ocp418-images

/test ocp419-ci-index-multiarch-tuning-operator-bundle

/test ocp419-e2e-gcp

/test ocp419-images

/test sast

/test unit

/test vendor

/test vet

The following commands are available to trigger optional jobs:

/test ocp417-azure-heterogeneous-perfscale

/test ocp417-azure-mto-heterogeneous-perfscale

/test security

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-multiarch-tuning-operator-main-bundle

pull-ci-openshift-multiarch-tuning-operator-main-ci-index-multiarch-tuning-operator-bundle

pull-ci-openshift-multiarch-tuning-operator-main-fmt

pull-ci-openshift-multiarch-tuning-operator-main-generate

pull-ci-openshift-multiarch-tuning-operator-main-goimports

pull-ci-openshift-multiarch-tuning-operator-main-images

pull-ci-openshift-multiarch-tuning-operator-main-lint

pull-ci-openshift-multiarch-tuning-operator-main-manifests

pull-ci-openshift-multiarch-tuning-operator-main-ocp416-ci-index-multiarch-tuning-operator-bundle

pull-ci-openshift-multiarch-tuning-operator-main-ocp416-e2e-gcp

pull-ci-openshift-multiarch-tuning-operator-main-ocp416-images

pull-ci-openshift-multiarch-tuning-operator-main-ocp417-ci-index-multiarch-tuning-operator-bundle

pull-ci-openshift-multiarch-tuning-operator-main-ocp417-e2e-gcp

pull-ci-openshift-multiarch-tuning-operator-main-ocp417-images

pull-ci-openshift-multiarch-tuning-operator-main-ocp418-ci-index-multiarch-tuning-operator-bundle

pull-ci-openshift-multiarch-tuning-operator-main-ocp418-e2e-gcp

pull-ci-openshift-multiarch-tuning-operator-main-ocp418-images

pull-ci-openshift-multiarch-tuning-operator-main-ocp419-ci-index-multiarch-tuning-operator-bundle

pull-ci-openshift-multiarch-tuning-operator-main-ocp419-e2e-gcp

pull-ci-openshift-multiarch-tuning-operator-main-ocp419-images

pull-ci-openshift-multiarch-tuning-operator-main-sast

pull-ci-openshift-multiarch-tuning-operator-main-security

pull-ci-openshift-multiarch-tuning-operator-main-unit

pull-ci-openshift-multiarch-tuning-operator-main-vendor

pull-ci-openshift-multiarch-tuning-operator-main-vet

In response to this:

/test ci/prow/ocp419-e2e-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@AnnaZivkovic
Copy link
Member

/test ocp419-e2e-gcp

@openshift-ci-robot
Copy link
Collaborator

/retest-required

Remaining retests: 0 against base HEAD f1d331d and 2 for PR HEAD cac44a5 in total

@AnnaZivkovic
Copy link
Member

/test ocp419-e2e-gcp

1 similar comment
@lwan-wanglin
Copy link
Member Author

/test ocp419-e2e-gcp

@lwan-wanglin
Copy link
Member Author

/retest

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 19, 2025
@lwan-wanglin
Copy link
Member Author

/test ocp416-e2e-gcp ocp418-e2e-gcp

@lwan-wanglin
Copy link
Member Author

/retest

@lwan-wanglin
Copy link
Member Author

/test ocp419-e2e-gcp

aleskandro
aleskandro reviewed May 19, 2025
View reviewed changes
aleskandro
aleskandro reviewed May 19, 2025
View reviewed changes
@lwan-wanglin
Copy link
Member Author

/retest

1 similar comment
@aleskandro
Copy link
Member

/retest

@AnnaZivkovic
Copy link
Member

/test ocp418-e2e-gcp

aleskandro
aleskandro reviewed May 19, 2025
View reviewed changes
Copy link
Member

@aleskandro aleskandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2025
@openshift-ci
Copy link

openshift-ci bot commented May 19, 2025

@lwan-wanglin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@AnnaZivkovic
Copy link
Member

/override "Red Hat Konflux / run-prowjob / multiarch-tuning-operator"

@openshift-ci
Copy link

openshift-ci bot commented May 19, 2025

@AnnaZivkovic: Overrode contexts on behalf of AnnaZivkovic: Red Hat Konflux / run-prowjob / multiarch-tuning-operator

In response to this:

/override "Red Hat Konflux / run-prowjob / multiarch-tuning-operator"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 80d90a9 into outrigger-project:main May 19, 2025
30 of 31 checks passed
@openshift-cherrypick-robot
Copy link

@aleskandro: new pull request created: #636

In response to this:

/cherry-pick v1.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Prashanth684 Prashanth684 Prashanth684 left review comments

@aleskandro aleskandro aleskandro approved these changes

@AnnaZivkovic AnnaZivkovic Awaiting requested review from AnnaZivkovic

Assignees

@Prashanth684 Prashanth684

@aleskandro aleskandro

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lwan-wanglin @openshift-ci-robot @aleskandro @openshift-cherrypick-robot @Prashanth684 @AnnaZivkovic