Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove footguns in IPC decoding and external string creation #17776

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DonIsaac
Copy link
Contributor

What does this PR do?

Follow-up to #17753

  • fix(ipc): Handle the unlikely scenario that a message larger than webkit's size limit is received
  • fix(string): strongly type context pointers when creating external strings
  • docs(string): start documenting memory characteristics of string constructors. I'll be adding more over time
  • refactor(string): remove RefString__free. It's only needed in one place and doesn't need to be a public API.

How did you verify your code works?

Existing tests should cover this.

@robobun
Copy link

robobun commented Feb 27, 2025

Updated 3:12 PM PT - Feb 27th, 2025

@DonIsaac, your commit 2abb46d has 1 failures in Build #12434:


🧪   try this PR locally:

bunx bun-pr 17776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants