Skip to content

fix(ws): allow blob to be set as WebSocket Client binaryType #18845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(ws): allow blob to be set as WebSocket Client binaryType #18845

wants to merge 3 commits into from
+50 −34

Conversation

Inqnuam
Copy link
Contributor

@Inqnuam Inqnuam commented Apr 8, 2025

Prevents #18807 to crash (caused by this), which enables client-server communication.
Unable to provide a test as WebSocketServer don't supports it

@Jarred-Sumner
Copy link
Collaborator

we never emit blobs currently though

@Inqnuam Inqnuam closed this Apr 9, 2025
@Inqnuam Inqnuam reopened this Apr 9, 2025
@Inqnuam
Copy link
Contributor Author

Inqnuam commented Apr 9, 2025

@Jarred-Sumner
In my last commit, I didn’t implement the best solution, but at least it allows sending and receiving Blob on both the Client and Server sides without crashing, and the tests are passing.
This solution might help unblock some libraries on Bun, but I’m not sure about the side effects.
Could you please trigger the pipeline?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Inqnuam @Jarred-Sumner