Skip to content

Fix and reorganize node:http #19021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

Fix and reorganize node:http #19021

wants to merge 17 commits into from

Conversation

heimskr
Copy link
Member

@heimskr heimskr commented Apr 15, 2025

What does this PR do?

Fixes some bugs in node:http and splits it up into multiple modules (_http_agent, _http_client, _http_incoming, _http_outgoing and _http_server) to match Node.js's organization.

  • Documentation or TypeScript types
  • Code changes

How did you verify your code works?

Ran existing node:http tests. None appear to have regressed.

@robobun
Copy link

robobun commented Apr 15, 2025

Updated 6:07 PM PT - Apr 14th, 2025

@heimskr, your commit 1de23d1 has 2 failures in Build #14940:


🧪   try this PR locally:

bunx bun-pr 19021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants