Skip to content

[RFC] Make inserted marker text secure-by-default #2064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[RFC] Make inserted marker text secure-by-default #2064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion overviewer_core/data/js_src/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,9 @@ overviewer.util = {
}
// Add popup to marker
if (marker_entry.createInfoWindow && db.text) {
layerObj.bindPopup(db.text);
layerObj.bindPopup(
document.createTextNode(db.text)
);
}
// Add the polyline or marker to the layer
marker_group.addLayer(layerObj);
Expand Down
1 change: 1 addition & 0 deletions overviewer_core/data/web_assets/leaflet.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,6 +472,7 @@ svg.leaflet-image-layer.leaflet-interactive path {
padding: 1px;
text-align: left;
border-radius: 12px;
white-space: pre-line;
}
.leaflet-popup-content {
margin: 13px 19px;
Expand Down