- 
                Notifications
    
You must be signed in to change notification settings  - Fork 111
 
feat(observability): add delete tenant action to tenant list page #20042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            yjaaouane
  merged 2 commits into
  project/observability
from
feat/MAOBS-105-tenant-delete
  
      
      
   
  Oct 30, 2025 
      
    
                
     Merged
            
            feat(observability): add delete tenant action to tenant list page #20042
                    yjaaouane
  merged 2 commits into
  project/observability
from
feat/MAOBS-105-tenant-delete
  
      
      
   
  Oct 30, 2025 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    darsene
  
              
              requested changes
              
                  
                    Oct 29, 2025 
                  
              
              
            
            
        
          
                packages/manager/apps/observability/src/__mocks__/tenants/tenant.adapter.ts
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                ...es/manager/apps/observability/src/__tests__/data/hooks/tenants/useDeleteTenant.hook.spec.tsx
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                ...es/manager/apps/observability/src/__tests__/data/hooks/tenants/useDeleteTenant.hook.spec.tsx
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                ...servability/src/components/listing/common/confirmation-modal/ConfirmationModal.component.tsx
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                packages/manager/apps/observability/src/data/api/tenants.api.ts
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                packages/manager/apps/observability/src/routes/Routes.constants.ts
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                packages/manager/apps/observability/src/routes/Routes.constants.ts
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                packages/manager/apps/observability/src/types/ClientApi.type.ts
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                ...r/apps/observability/src/components/listing/tenants/actions/TenantsListActions.component.tsx
              
                Outdated
          
            Show resolved
            Hide resolved
        
      831db16    to
    e64f4b0      
    Compare
  
    e64f4b0    to
    1c28d4a      
    Compare
  
    ref: #MAOBS-105 Signed-off-by: yjaaouane <[email protected]>
ref: #MAOBS-105 Signed-off-by: yjaaouane <[email protected]>
1c28d4a    to
    173e1b2      
    Compare
  
    
              
                    darsene
  
              
              approved these changes
              
                  
                    Oct 30, 2025 
                  
              
              
            
            
              
                    MarcMonchablon
  
              
              approved these changes
              
                  
                    Oct 30, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for the listing.lazy file, which I believe can be removed by doing regular lazy import in routes, everything else is fine :)
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Description
Ticket Reference: #MAOBS-105
Additional Information