- 
                Notifications
    You must be signed in to change notification settings 
- Fork 110
feat(pci-instances): add image section with helper drawer #20050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            Tsiorifamonjena
  merged 1 commit into
  feat/add-instance-creation-page-TAPC-4445
from
feat/TAPC-4614
  
      
      
   
  Oct 30, 2025 
      
    
                
     Merged
            
            feat(pci-instances): add image section with helper drawer #20050
                    Tsiorifamonjena
  merged 1 commit into
  feat/add-instance-creation-page-TAPC-4445
from
feat/TAPC-4614
  
      
      
   
  Oct 30, 2025 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    ab693b7    to
    305f022      
    Compare
  
            
          
                packages/manager/apps/pci-instances/src/hooks/url/useGuideLink.constant.ts
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                packages/manager/apps/pci-instances/src/hooks/url/useGuideLink.constant.ts
          
            Show resolved
            Hide resolved
        
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great ! One more step towards our goal. Nice work 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well done for guides part !!!
        
          
                ...-instances/src/pages/instances/create/components/distributionImage/ImageHelper.component.tsx
          
            Show resolved
            Hide resolved
        
              
          
                packages/manager/apps/pci-instances/src/hooks/url/useGuideLink.constant.ts
              
                Outdated
          
            Show resolved
            Hide resolved
        
      305f022    to
    9b5933d      
    Compare
  
    fa2f02b    to
    9b5933d      
    Compare
  
    
              
                    manoncarbonnel
  
              
              approved these changes
              
                  
                    Oct 29, 2025 
                  
              
              
            
            
9ffedba    to
    3ca6b2c      
    Compare
  
    ref: #TAPC-4614, #TAPC-4652 Signed-off-by: tsiorifamonjena <[email protected]> Co-authored-by: CDS Translator Agent <[email protected]>
3ca6b2c    to
    c7e3090      
    Compare
  
    
              
                    lolottetheclash
  
              
              approved these changes
              
                  
                    Oct 30, 2025 
                  
              
              
            
            
84e23a7
      into
      
  
    feat/add-instance-creation-page-TAPC-4445
  
    
        15 checks passed
      
      
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Description
This PR add the Distribution Image section to the creation page (title and helper).
It also refactor and rework the
useGuideLinkhook to be able to take more than one helper keyI use typescript feature overloading function with distinct signature to infer the return type :
Ticket Reference: #TAPC-4614, #TAPC-4652
Additional Information