Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix secrets commands #53

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: fix secrets commands #53

wants to merge 1 commit into from
+42 −31

Conversation

inessebz
Copy link
Contributor

No description provided.

@inessebz inessebz requested a review from a team as a code owner March 12, 2025 15:50
@inessebz inessebz force-pushed the fix/ibenzekr/secrets branch from f88ad52 to 897b5e6 Compare March 12, 2025 16:04
ldesauw
ldesauw reviewed Mar 13, 2025
View reviewed changes
cmd/okms/secrets/secrets.go
var v []uint32
for _, val := range versions {
v = append(v, utils.ToUint32(val))
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This loop is repeated twice, maybe write a function ToUint32Array that does it.

ldesauw
ldesauw reviewed Mar 13, 2025
View reviewed changes
common/utils/int.go
panic("Integer overflow")
}
return uint32(n)
}

// func ToUint16[N Integer](n N) uint16 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unnecessary code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldesauw ldesauw ldesauw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inessebz @ldesauw